[theme-reviewers] Editing core shortcodes (Gallery)

[Daniel Tara]

A common problem when themes do his is that they override the functionality of other plugins like Jetpack, however that can be avoided with just a simple check:

require_once( ABSPATH . 'wp-admin/includes/plugin.php' );
if( is_plugin_active( 'jetpack/jetpack.php' ) && in_array( 'tiled-gallery', Jetpack::get_active_modules() ) )
	return '';

Other than that I don't see any reason why themes shouldn't hack into the gallery short code, it's presentational after all.

Daniel

On Mar 26, 2013, at 8:26 PM, Jeremy Herve wrote:

> Hi there,
> 
> I found that some themes in the repo currently include functions that customize the output of the Gallery shortcode.
> 
> I wonder if this is something we want to promote in the theme repo. Isn't it something that should remain in the plugin territory?
> 
> It is sometimes hard to troubleshoot gallery issues in the forums; you start by suggesting that they disable all image and gallery plugins, but that doest help. Unless you know the theme, you have no way to know if that theme actually includes functions that make changes to core WordPress features.
> 
> What do you think? Is it something that could be added to the theme guidelines?
> 
> Cheers,
> 
> Jeremy
> 
> --
> Jeremy Herve
> http://jeremyherve.com
> http://twitter.com/jeherve
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130326/2a0748ed/attachment.htm>