[theme-reviewers] Question about implementation of theme hooks / template tags system
chip at chipbennett.net
Mon Mar 18 18:15:41 UTC 2013
I think that the interpretation in the linked ticket is valid, and applies
This implementation entirely circumvents the
Hierarchy, and adds its own, custom abstraction layer. Themes are required
to support core functionality when integrating a given feature. I would
suggest that this requirement extends to the template hierarchy itself.
You may want to look at a combination of template-part files and custom
Theme hooks to accomplish the same thing that you're attempting to do here.
So, let's start the discussion there.
Is that interpretation correct? I I'm open to being convinced otherwise.
On Mon, Mar 18, 2013 at 1:57 PM, Daniel Tara <contact at onedesigns.com> wrote:
> Hello Theme Reviewers Team,
> I would like to receive clarification if a theming method I'm implementing
> is in compliance with the Theme Review Guidelines.
> I'm currently building a theme framework that will serve as a base for all
> my future theme implementations. The framework consists of a series of
> common functions and template tags that are to be used inside templates.
> The functions are written in such way that they can be used as both hard
> coded template tags, with a set of predefined options that can be
> overridden by parameters and also to be used with a template hook system
> and their options can be modified via filters. I'm also planning to build a
> module that will allow control of the template hooks via conditionals and
> eventually integrate all this into a drag-and-drop module that will allow
> user customization of template tags locations.
> I have taken the care to comply with all Theme Review Guidelines and
> WordPress Best Practices when coding this theme, including complying with
> the Template Hierarchy. The only template file a parent theme would need to
> work with this module is index.php with the template hooks included. Then,
> if a user wishes to add a template in a child theme, it will still be used
> for the corresponding query type and if the user adds the standard template
> hooks to the file then the framework's module would still work because the
> conditionals would return the corresponding values for the template and if
> not the template could still be customized by hard coding template tags.
> I'm asking this question because a discussion that took place recently on
> the mailing list regarding a theme came to my attention, namely this one:
> In the ticket it was argued that the way that theme was implementing its
> template hooks system was circumventing the Template Hierarchy and hard
> coding template files was recommended. I haven't examined that theme in
> detail because after a quick look the poor implementation of the feature
> was clear but it was still a template hooks system, so I felt the need to
> ask: is it theme review policy to strictly forbid a template hooks system
> and require the use of hard coded template files for any customization of
> WordPress-generated pages or was that something specific in the way that
> theme was implementing this feature that made it be rejected? If such a
> system is not allowed do you have recommendation of an accepted way to
> implement a module that allows user customization of page output?
> An earlier version of the theme I'm talking about was already submitted to
> the directory, it was reviewed and not-approved for trivial reasons but the
> use of the template hooks system was not mentioned:
> But since review of the theme I mentioned earlier has set a precedent I
> felt the need to ask. Since the theme above was submitted the theme has
> been under heavy development and much has changed but the way the template
> hooks system was implemented still stands. Eventually the hardcoded hooks
> at the end of the functions.php file will be replaced with the conditionals
> module I was talking about which is not yet developed. If needed I can send
> a current version of the theme so you can take a closer look.
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the theme-reviewers