[theme-reviewers] Tinymce button that only adds css codes.. still plugin territory?

Sun Mar 3 14:26:13 UTC 2013

Are we talking about core-defined shortcodes or not? If they're defined in
core, why do they need to be defined in the Theme?

On Sun, Mar 3, 2013 at 9:23 AM, Ünsal Korkmaz <unsalkorkmaz at gmail.com>wrote:

> So why is the Theme including core-defined shortcodes?
>
> Uh..
> http://codex.wordpress.org/Theme_Unit_Test
> I just supported default wordpress shortcodes.. video,audio and gallery..
> Is it not allowed too? god.. what is wrong with community..
>
> Post Format Test: Video
>
>    - Video displays as intended in the index view
>    - Video does not overflow the content area
>
> Post Format Test: Audio
>
>    - Enclosure links work properly.
>
>
> On Sun, Mar 3, 2013 at 4:17 PM, Chip Bennett <chip at chipbennett.net> wrote:
>
>> So why is the Theme including core-defined shortcodes?
>>
>> As for the TinyMCE buttons: I explained that. To repeat:
>>
>> But, for the TinyMCE buttons: my initial reaction would be to say that
>> they also are probably Plugin territory. What do the buttons do? What do
>> they add to the post content? Wrap selected content in <span class="foo
>> bar"></span> tags? Sure, that degrades more gracefully than un-parsed
>> shortcodes, but it would still result in a bunch of unused markup scattered
>> throughout the user's posts after switching Themes. *Thus, I would say
>> that the TinyMCE buttons are also Plugin territory*. I would recommend
>> defining the *styles* for the CSS classes added via the TinyMCE buttons,
>> but make the underlying TinyMCE button functionality itself a Plugin.
>>
>>
>> On Sun, Mar 3, 2013 at 9:15 AM, Ünsal Korkmaz <unsalkorkmaz at gmail.com>wrote:
>>
>>> There is no [audio], [gallery], and [video] buttons in the TinyMCE
>>> editor.. as i said clearly tinymce button is only adding css code.
>>>
>>>
>>> On Sun, Mar 3, 2013 at 4:14 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>
>>>> I'd still say that's Plugin territory. Rule-of-thumb question: would
>>>> the end user want, and reasonably expect, for that functionality to remain,
>>>> regardless of what Theme is active? Having [audio], [gallery], and [video]
>>>> buttons in the TinyMCE editor would certainly be a "yes" to that question.
>>>> That's why it's Plugin territory.
>>>>
>>>>
>>>> On Sun, Mar 3, 2013 at 9:10 AM, Ünsal Korkmaz <unsalkorkmaz at gmail.com>wrote:
>>>>
>>>>> Thank you for review but i mean tinymce does not adding shortcode, it
>>>>> adds css code.
>>>>>
>>>>> http://themes.svn.wordpress.org/firmasite/1.1.0/functions/shortcodes.php
>>>>> Those shortcodes are wordpress's default shortcodes. audio, gallery,
>>>>> video.
>>>>>
>>>>>
>>>>> On Sun, Mar 3, 2013 at 4:07 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>>>
>>>>>> Hmm, actually, there *are* shortcodes:
>>>>>>
>>>>>> http://themes.svn.wordpress.org/firmasite/1.1.0/functions/shortcodes.php
>>>>>>
>>>>>> And this is definitely Plugin territory:
>>>>>>
>>>>>> http://themes.svn.wordpress.org/firmasite/1.1.0/functions/remove-comments-absolute.php
>>>>>>
>>>>>> And a good deal of this is Plugin territory:
>>>>>> http://themes.svn.wordpress.org/firmasite/1.1.0/functions/fix.php
>>>>>>
>>>>>> And this is also probably Plugin territory (though a bit of a gray
>>>>>> area):
>>>>>>
>>>>>> http://themes.svn.wordpress.org/firmasite/1.1.0/functions/custom-sharing-buttons.php
>>>>>>
>>>>>> http://themes.svn.wordpress.org/firmasite/1.1.0/functions/custom-facebook-comments.php
>>>>>>
>>>>>> But, for the TinyMCE buttons: my initial reaction would be to say
>>>>>> that they also are probably Plugin territory. What do the buttons do? What
>>>>>> do they add to the post content? Wrap selected content in <span class="foo
>>>>>> bar"></span> tags? Sure, that degrades more gracefully than un-parsed
>>>>>> shortcodes, but it would still result in a bunch of unused markup scattered
>>>>>> throughout the user's posts after switching Themes. *Thus, I would
>>>>>> say that the TinyMCE buttons are also Plugin territory*. I would
>>>>>> recommend defining the *styles* for the CSS classes added via the TinyMCE
>>>>>> buttons, but make the underlying TinyMCE button functionality itself a
>>>>>> Plugin.
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Chip
>>>>>>
>>>>>>
>>>>>> On Sun, Mar 3, 2013 at 8:00 AM, Ünsal Korkmaz <unsalkorkmaz at gmail.com
>>>>>> > wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>> My theme:
>>>>>>> http://themes.trac.wordpress.org/ticket/11437
>>>>>>> Theme is adding custom tinymce button that adds css code for design
>>>>>>> elements. There is no shortcode or something.. just css code.
>>>>>>> Its allowed in themes right?
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> theme-reviewers mailing list
>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130303/4755ce7d/attachment.htm>