[theme-reviewers] Tinymce button that only adds css codes.. still plugin territory?

[Chip Bennett]

Hmm, actually, there *are* shortcodes:
http://themes.svn.wordpress.org/firmasite/1.1.0/functions/shortcodes.php

And this is definitely Plugin territory:
http://themes.svn.wordpress.org/firmasite/1.1.0/functions/remove-comments-absolute.php

And a good deal of this is Plugin territory:
http://themes.svn.wordpress.org/firmasite/1.1.0/functions/fix.php

And this is also probably Plugin territory (though a bit of a gray area):
http://themes.svn.wordpress.org/firmasite/1.1.0/functions/custom-sharing-buttons.php
http://themes.svn.wordpress.org/firmasite/1.1.0/functions/custom-facebook-comments.php

But, for the TinyMCE buttons: my initial reaction would be to say that they
also are probably Plugin territory. What do the buttons do? What do they
add to the post content? Wrap selected content in <span class="foo
bar"></span> tags? Sure, that degrades more gracefully than un-parsed
shortcodes, but it would still result in a bunch of unused markup scattered
throughout the user's posts after switching Themes. *Thus, I would say that
the TinyMCE buttons are also Plugin territory*. I would recommend defining
the *styles* for the CSS classes added via the TinyMCE buttons, but make
the underlying TinyMCE button functionality itself a Plugin.

Regards,

Chip


On Sun, Mar 3, 2013 at 8:00 AM, Ünsal Korkmaz <unsalkorkmaz at gmail.com>wrote:

> Hi,
> My theme:
> http://themes.trac.wordpress.org/ticket/11437
> Theme is adding custom tinymce button that adds css code for design
> elements. There is no shortcode or something.. just css code.
> Its allowed in themes right?
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130303/074bf431/attachment-0001.htm>