[theme-reviewers] Remove Debug Bar from recommended plugins

[Mario Peshev]

Imagine the following scenario:

You review a theme, it looks okay. You send it to person X who deploys it
on a live server which happens to have WP_DEBUG as true (as all of the site
content is working fine so fine, plugins, content and previous theme so no
issues noticed until now).

It would spit all errors on the front screen as the plugin is hiding them
all.

How would that be useful?


Mario Peshev
WordPress Engineer, Open Source Consultant
http://www.linkedin.com/in/mpeshev
http://me.peshev.net



On Sun, Jun 30, 2013 at 2:28 AM, Josh Pollock <jpollock412 at gmail.com> wrote:

> Isn't that what the log deprecated calls plugin is for?
>
>
> On Sat, Jun 29, 2013 at 7:24 PM, Mario Peshev <mario at peshev.net> wrote:
>
>> Deprecated calls in particular - get_bloginfo with arguments, or
>> wp_list_cats() - the deprecation notices are not displayed on my installs
>> with Debug Bar (testing themes coded long ago).
>>
>>
>> Mario Peshev
>>
>>
>>
>> On Sun, Jun 30, 2013 at 2:21 AM, Josh Pollock <jpollock412 at gmail.com>wrote:
>>
>>> Can you elaborate about what notices you think it is suppressing? I'd be
>>> willing to try and recreate this issue if you could provide more details.
>>> Like a lot of people, I have debug bar activated on all of my development
>>> and testing sites.
>>>
>>>
>>> On Sat, Jun 29, 2013 at 7:11 PM, Mario Peshev <mario at peshev.net> wrote:
>>>
>>>> Everyone, I'd like to propose a removal of Debug Bar from the
>>>> recommended plugins for testing (on pages like
>>>> http://make.wordpress.org/themes/about/how-to-join-wptrt/ or any other
>>>> pages in Codex related to Theme Review or Theme Unit Test data).
>>>>
>>>> I'm usually testing on several different installs and I finally found
>>>> out that Debug Bar is hiding some notices on a default install with a
>>>> default setup (say, blank WP, WP_DEBUG as true and imported test data). It
>>>> seems to have some custom error handling or something, but I don't see the
>>>> issues on the frontend when the plugin is enabled.
>>>>
>>>> Apologies in advance if I'm missing anything, but from my perspective
>>>> it's suppressing actual notices/warnings which is not healthy for the
>>>> review process.
>>>>
>>>> Mario Peshev
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130630/09fecd1f/attachment.html>