[theme-reviewers] First time Review

[Abhik Biswas]

If the author needs to output custom/modified titles, it should be done by
filtering wp_title(). So, no, it's not okay.

Just my 2 cents


On Sat, Jun 15, 2013 at 9:50 AM, Mohammad Hussain <
hussain at hitechbloggers.com> wrote:

>  On 6/15/2013 9:48 AM, Chip Bennett wrote:
>
> This is the third different thread you've asked this same question in. It
> will be easier to ensure that your question gets answered satisfactorily if
> you keep it to a single email thread. We're here to help, and to answer
> questions, but asking and answering the same question three times isn't the
> most efficient use of your time or ours. :)
>
>
> On Fri, Jun 14, 2013 at 11:59 PM, Mohammad Hussain <
> hussain at hitechbloggers.com> wrote:
>
>>   On 6/15/2013 9:27 AM, Emil Uzelac wrote:
>>
>> Just go to http://codex.wordpress.org/Theme_Review and review
>> the Theme against the guidelines. If you have any questions please
>>  feel free to ask away!
>>
>>  Emil
>>
>>
>> On Fri, Jun 14, 2013 at 10:55 PM, Mohammad Hussain <
>> hussain at hitechbloggers.com> wrote:
>>
>>> First time I reviewing the theme.Can anyone let me know what can I do,
>>>  thing that i must know while reviewing the theme??
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>   in Theme Review the tags are are required like:
>> If someone uses custom code instead of using wp_title() in between
>> <title></title>.Can this is OK or should I tell to author to change it to
>> wp_title() instead of using their own custom made code.
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
> _______________________________________________
> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>  Ok I got it...so author added this code inside <title> tag
>
> <title><?php
> 		/*
> 		 * Print the <title> tag using HTMLkombinat::HTML_Kombinat_the_title()
> 		 * @see core/htmlkombinat-class.php
> 		 */
> 		htmlkombinat::HTML_Kombinat_the_title();
> 	?></title>
>
> this code author added
> is this ok or not?
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130615/8f32b995/attachment.html>