[theme-reviewers] Questions on my first review

[Otto]

On Mon, Jun 10, 2013 at 8:54 PM, J.J. Springer <jjgspringer at gmail.com> wrote:
> 2. If I get any error of any sort, I assume that means that the theme is
> automatically rejected. As soon as I run into an error, do I stop and mark
> it rejected or keep going and try to find as many errors as possible? Is
> there a point at which I should just stop and send it back?

This is up to you. Additionally, I apologize for usurping your review
and failing the theme, but that kind of ticked me off a bit.

If you wish to do a full review and give the theme author more tips
and things that he needs to check on, that's perfectly acceptable.

> 3. The theme that I'm reviewing is a child theme of twentytwelve and
> therefore doesn't have the "required" theme template files (missing
> comments.php). Are child themes allowed? Is there some special way that I'm
> supposed to be reviewing them?

Child themes won't pass theme check, obviously, because of missing
files and such. The review guidelines still stand though, and the
child+parent must pass, as a whole, sort of thing. The parent is
presumed to already have passed, since it's in the directory anyway.


> 4. The person that I'm reviewing used a lot framework stuff that's MIT or
> WTFPL licensed. Is that ok?

Both of those are GPL-Compat, so they're fine.


-Otto