[theme-reviewers] Questions on my first review

[Otto]

On Mon, Jun 10, 2013 at 8:54 PM, J.J. Springer <jjgspringer at gmail.com> wrote:
> 1. When I run Theme Check, I need up getting two warnings and a bunch of
> other "INFO" lines. Is the theme automatically rejected if it generates the
> following errors:
>
> Here are the warnings:
>
> WARNING: Found base64_encode in the file
> admin/classes/class.options_machine.php. base64_encode() is not allowed.
>
>     Line 489: $output .= '<textarea id='export_data'
> rows='8'>'.base64_encode(serialize($jaguza_data)) /* 100% safe - ignore
> theme check na
>
>     WARNING: Found base64_decode in the file
> admin/functions/functions.interface.php. base64_decode() is not allowed.
>
>     Line 223: $jaguza_data = unserialize(base64_decode($jaguza_data));
> //100% safe - ignore theme check nag


No, not allowed, failed. There is no "theme check nag", use of base64
is not allowed in themes in the repository, period.


> ALSO, are the INFO "errors" counted as errors and cause the theme to be
> rejected?


No, info can be ignored, as it's just info. Warnings = fail.


-Otto