[theme-reviewers] Rems in theme unit test data file

Stuart Wider stuartwider at gmail.com
Fri Jun 7 18:49:16 UTC 2013


Hi Emil,

You'll also find the rems in these places...ack!
http://wpthemetestdata.wordpress.com/2013/01/10/markup-image-alignment/
http://wpthemetestdata.wordpress.com/2013/01/05/markup-title-with-markup/
http://wpthemetestdata.wordpress.com/2012/01/03/template-comments/
http://wpthemetestdata.wordpress.com/2009/10/05/edge-case-non-breaking-text/
http://wpthemetestdata.wordpress.com/2009/05/15/edge-case-nested-and-mixed-lists/


On Fri, Jun 7, 2013 at 7:14 PM, Emil Uzelac <emil at uzelac.me> wrote:

> Just fixed that, it was not needed :)
>
>
> http://wpthemetestdata.wordpress.com/2012/01/01/template-pingbacks-an-trackbacks/
>
>
> On Fri, Jun 7, 2013 at 8:09 AM, Stuart Wider <stuartwider at gmail.com>wrote:
>
>> Hi Edward,
>> Thanks for explaining why its there.
>>
>>
>> On Fri, Jun 7, 2013 at 1:46 PM, Edward Caissie <edward.caissie at gmail.com>wrote:
>>
>>> Although I am not a fan of inline styles in most cases, keep in mind
>>> this text is for reference purposes only.
>>> The inline styles help insure this "instructional" text is readable.
>>>
>>> Edward Caissie
>>> aka Cais.
>>>
>>>
>>> On Fri, Jun 7, 2013 at 8:15 AM, Stuart Wider <stuartwider at gmail.com>wrote:
>>>
>>>> Upon investigation it the rems in the theme test unit data will affect
>>>> the text formatting of themes which use the popular 62.5% em sizing css
>>>> technique (this includes the underscores starter theme).
>>>> http://clagnut.com/blog/348/.
>>>> I'd suggest removing those errant rems from the test data file.
>>>>
>>>>
>>>> On Fri, Jun 7, 2013 at 12:38 PM, Stuart Wider <stuartwider at gmail.com>wrote:
>>>>
>>>>> Further to that when I look at
>>>>>
>>>>> http://wpthemetestdata.wordpress.com/2012/01/01/template-pingbacks-an-trackbacks/
>>>>> It seems to cause list font size strangeness even on the Theme unit
>>>>> test data site too.
>>>>>
>>>>>
>>>>> On Fri, Jun 7, 2013 at 11:45 AM, Alberto Ramacciotti <
>>>>> ramacciotti.alberto at gmail.com> wrote:
>>>>>
>>>>>>  Apart that I dont recommend to use inline style, rems is a well
>>>>>> known thing.
>>>>>>
>>>>>> Il 07/06/2013 12:37, Stuart Wider ha scritto:
>>>>>>
>>>>>> Hi Guys,
>>>>>>
>>>>>>  I'm just running through a self review of my own theme before
>>>>>> submission and I notice in the the latest downloaded theme unit test data
>>>>>> file posts with html like this...
>>>>>>
>>>>>>  ---snip--
>>>>>>
>>>>>>  This post has many pingpacks and trackbacks.
>>>>>> There are a few ways to list them.
>>>>>> <ol>
>>>>>>  <li><span style="line-height:1.714285714;font-size:1rem;">Above the
>>>>>> comments.</span></li>
>>>>>>  <li><span style="line-height:1.714285714;font-size:1rem;">Below the
>>>>>> comments</span></li>
>>>>>>  <li><span style="line-height:1.714285714;font-size:1rem;">Included
>>>>>> within the normal flow of comments.</span></li>
>>>>>> </ol>
>>>>>>
>>>>>>  --end of snip---
>>>>>>
>>>>>>  It seems strange to have line height and rem units in what is just
>>>>>> a basic list.
>>>>>>  Is there any particular reason for rems and line-height appearing
>>>>>> there?
>>>>>>
>>>>>>  Thanks,
>>>>>> Stuart
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Alberto Ramacciotti
>>>>>> Sviluppo Webhttp://arwebdevstudio.it
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130607/6ea53deb/attachment-0001.html>


More information about the theme-reviewers mailing list