[theme-reviewers] Need clarification on Guideline.

Chip Bennett chip at chipbennett.net
Tue Jul 16 22:33:00 UTC 2013


And also, just to note: @import or enqueueing an external stylesheet is
extremely limited. It should only be used for a trusted, third-party API
like Google Fonts.

Any stylesheets that *can* be bundled with the Theme *should* be, rather
than enqueued externally.

But, as Emil said: in this case, whether you @import or enqueue, either
should be just fine.


On Tue, Jul 16, 2013 at 6:25 PM, Emil Uzelac <emil at uzelac.me> wrote:

> Maybe this will explain better.
>
> Needs to be enqueued:
>
> <link href='http://fonts.googleapis.com/css?family=Fauna+One'
> rel='stylesheet' type='text/css'>
>
> Does not need to be:
>
> @import url(http://fonts.googleapis.com/css?family=Fauna+One);
>
> If handled from style.css
>
> For the references how to include Google Fonts in i.e. functions.php
> please see
> http://themes.svn.wordpress.org/babylog/2.1/functions.php
>
>
> On Tue, Jul 16, 2013 at 5:16 PM, Emil Uzelac <emil at uzelac.me> wrote:
>
>> No sir, it does not need to be.
>>
>>
>> On Tue, Jul 16, 2013 at 5:15 PM, Stephen Cui <scui2005 at gmail.com> wrote:
>>
>>> Ok. But google font need to be enqueued?
>>>
>>> Stephen
>>>
>>>
>>> On Jul 16, 2013, at 5:07 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>
>>> @import's are actually fine, if they're in the style.css no need to
>>> enqueue.
>>>
>>>
>>> On Tue, Jul 16, 2013 at 5:05 PM, Stephen Cui <scui2005 at gmail.com> wrote:
>>>
>>>> Based on the guidelines:
>>>>
>>>> Themes are *required* to enqueue all stylesheets and scripts.
>>>>
>>>> Example:
>>>>
>>>> @import url(http://fonts.googleapis.com/css?family=Cuprum&subset=latin);
>>>> @import url(media/css/my/reset.css);
>>>> @import url(media/css/settings.css);
>>>> @import url(media/css/widget.css);
>>>> @import url(media/css/comment.css);
>>>>
>>>> I believe the example here is against the guideline. Correct me if I am wrong.
>>>>
>>>> Regards
>>>>
>>>> Stephen
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130716/020a3765/attachment.html>


More information about the theme-reviewers mailing list