[theme-reviewers] help with review

Tue Jul 2 17:28:54 UTC 2013

Then there shouldn't be a problem with that, I wouldn't think...

On Tue, Jul 2, 2013 at 1:27 PM, Srikanth Koneru <tskk79 at gmail.com> wrote:

> yes
>
>
> On Tue, Jul 2, 2013 at 10:57 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> That makes more sense. :)
>>
>> Is it normal embed code?
>>
>>
>> On Tue, Jul 2, 2013 at 1:23 PM, Srikanth Koneru <tskk79 at gmail.com> wrote:
>>
>>> those buttons don't share that theme options page but share the url of
>>> my theme shop....
>>>
>>>
>>> On Tue, Jul 2, 2013 at 10:50 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>
>>>> How do you "share" a Theme options page? Since only authenticated users
>>>> can access the page ostensibly being "shared", that seems a bit silly, no?
>>>>
>>>>
>>>> On Tue, Jul 2, 2013 at 1:15 PM, Srikanth Koneru <tskk79 at gmail.com>wrote:
>>>>
>>>>> Theme option pages?
>>>>> Are social sharing buttons allowed there? My themes have them...
>>>>>
>>>>>
>>>>> On Tue, Jul 2, 2013 at 10:42 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>>>
>>>>>> From your "Theme pages"? I'm not sure I follow (no pun intended)...
>>>>>>
>>>>>>
>>>>>> On Tue, Jul 2, 2013 at 1:08 PM, Greg Priday <greg at siteorigin.com>wrote:
>>>>>>
>>>>>>> I think I know the answer to this already, but does this mean I have
>>>>>>> to remove the Facebook like and Twitter follow buttons from my theme pages
>>>>>>> (they're iframes)?
>>>>>>>
>>>>>>> I'll miss being popular :(
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Jul 2, 2013 at 7:02 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>>>>>
>>>>>>>> Phone-home script? Yeah, looking at it, that's bad. I'm immediately
>>>>>>>> suspending all Themes from this developer. Feel free to close/not-approved
>>>>>>>> all open tickets.
>>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, Jul 2, 2013 at 12:46 PM, Zulfikar Nore <
>>>>>>>> zulfikarnore at live.com> wrote:
>>>>>>>>
>>>>>>>>> If I may add - all themes by this reporter (previously suspended
>>>>>>>>> for license compatibility) seem to have the same contact form in them.
>>>>>>>>>
>>>>>>>>> A quick SVN comparison to the ticket Kavita reviewed shows the
>>>>>>>>> same pattern as they all contain almost the same file structure. here are
>>>>>>>>> the ticket numbers in question...
>>>>>>>>>
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12795
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12796
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12797
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12798
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12800
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12801
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12802
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12805
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12813
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12803 - has the iframe in
>>>>>>>>> functions.php
>>>>>>>>>
>>>>>>>>> File in question is
>>>>>>>>> http://themes.svn.wordpress.org/theme-name/cfg/admin/settings/contact.php- not tested if they are indeed iframes, just going by the pattern at the
>>>>>>>>> moment.
>>>>>>>>>
>>>>>>>>> I could be wrong on this but themes also seem to have a phone home
>>>>>>>>> script pointing to http://wpstats.mythem.es/?theme= with the
>>>>>>>>> extraction of user first_name' user last_name, user_login and user_email -
>>>>>>>>> this is triggered by activation and deactivation of the theme.
>>>>>>>>>
>>>>>>>>> For ticket #12795 the suspected phone home script is located in
>>>>>>>>> theme-name/fw/mytheme.class.php - could be same for the rest of themes but
>>>>>>>>> I think I notice one located in the functions.php.
>>>>>>>>>
>>>>>>>>> Should we go through these and close them on per ticket basis
>>>>>>>>> sighting the review @ #12793<http://themes.trac.wordpress.org/ticket/12793> or
>>>>>>>>> can an Admin do an SVN comaprison and close all tickets sighting the same
>>>>>>>>> review?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ------------------------------
>>>>>>>>> Date: Tue, 2 Jul 2013 09:13:11 -0400
>>>>>>>>> From: chip at chipbennett.net
>>>>>>>>> To: theme-reviewers at lists.wordpress.org
>>>>>>>>> Subject: Re: [theme-reviewers] help with review
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> No. Themes should not link to any external resource. They can
>>>>>>>>> provide a link to the external content, or include the content internally.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Tue, Jul 2, 2013 at 9:11 AM, Kavita Kumawat <erkavecb at gmail.com
>>>>>>>>> > wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I was reviewing this theme and the developer has put the iframe in
>>>>>>>>> theme options, linking to his website to be contacted.. is this allowed??
>>>>>>>>>
>>>>>>>>> http://themes.trac.wordpress.org/ticket/12793
>>>>>>>>>
>>>>>>>>> thanks in advance
>>>>>>>>> kavita
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________ theme-reviewers
>>>>>>>>> mailing list theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> theme-reviewers mailing list
>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> I make free WordPress themes
>>>>>>> http://siteorigin.com
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> theme-reviewers mailing list
>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130702/6ff476b6/attachment.html>