[theme-reviewers] Bugs in the Unit Test Data

Tue Jul 2 08:12:22 UTC 2013

Just to add that "Scheduled" post is actually published when you import
test data.
Not sure if this was discussed?

On 2 July 2013 05:00, Emil Uzelac <emil at uzelac.me> wrote:

> Let's start from the top, answering inline:
>
> 1) There's a post title called "Markup: Title with Markup", but the export
> seems to have stripped the markup, or the <b> and <i>, or <strong> and <em>
> were never actually included. Modifying the post so it becomes "Markup:
> Title <i>with</i> <b>Markup</b>" now enables potential passing of the test.
> See http://demo.gamajo.com/sample/**2013/01/markup-title-with-**markup/<http://demo.gamajo.com/sample/2013/01/markup-title-with-markup/> (if
> you change the h1 font-weight to 100, you'll see that the final word is
> indeed bold).
>
> *Fixed*
>
>
> 2) This image 404s from the import data: http://wpthemetestdata.files.**
> wordpress.com/2008/06/**dsc20050813_115856_52.jpg<http://wpthemetestdata.files.wordpress.com/2008/06/dsc20050813_115856_52.jpg>
> .
>
> *Cannot Reproduce*
>
>
> 3) There's a comment by John Saddington that uses a [youtube ...]
> shortcode. I'm not sure if this is supported in JetPack, but if so, it's
> not mentioned within the comment, and if not, then perhaps a [video...]
> shortcode or oEmbeded link might be better.
>
> *Removed*
>
>
> 4) On the Comments post, there's a 2-3 posts by Michael Novotny that say
> it is an Author comment as well. Obviously trickier if the post is imported
> and assigned to a new or existing user, but the comments seem to be made by
> someone who isn't any of the default authors, so I don't think it would
> ever match up. There's also another comment which mentions "Author comment"
> made by Alex, yet his user ID is 0, so that would never the relevant post
> author class to appear either.
>
> *Need specific comments*
>
>
> --
>
> I also noticed the commenters on the "Template: Comments" changed to be
> mostly folks from the 8bit team.  They're great guys, but I think it might
> be more appropriate to have the unit test data be completely non-commercial
> (remove links to companies, etc).  (No mail list drama y'all.  Just +1 if
> you like.)
>
> I believe a theme team admin will need to make these changes, so just
> wanted to pass it on.
>
> *Done. All goes to example.org*
>
>
> On Mon, Jul 1, 2013 at 8:48 PM, Emil Uzelac <emil at uzelac.me> wrote:
>
>> BTW (and sorry)
>>
>> #1 was already fixed, it was due to:
>>
>> <span style="line-height: 1.714285714; font-size: 1rem;">The post title
>> renders the word “with” in </span>
>>
>> No need to use anything like that in lists, still not available, but it
>> will be soon :)
>>
>>
>> On Mon, Jul 1, 2013 at 8:46 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>
>>> All commercial, personal etc links are now http://example.org/ and
>>> let's keep
>>> it that way. Going over the rest now and once we're done, I'll ping
>>> Lance to
>>> refresh the data for us.
>>>
>>>
>>> On Mon, Jul 1, 2013 at 8:35 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>
>>>> Hey Devin,
>>>>
>>>> Agreed on the non-commercial links, let's go with wordpress.org,
>>>> automattic.com and example.com instead.
>>>> No need to go above that. Shortcode test would not work and no need to
>>>> test plugins with the Themes.
>>>>
>>>> BTW the Genesis titles from the demo need: word-break: break-word; ;)
>>>>
>>>> I will go over the data now.
>>>>
>>>> Emil
>>>>
>>>>
>>>> On Mon, Jul 1, 2013 at 8:20 PM, Devin Price <devin at wptheming.com>wrote:
>>>>
>>>>> Hi.  Someone I follow on twitter (@GaryJ) noticed a few bugs in the
>>>>> Theme Unit Test Data (http://codex.wordpress.org/**Theme_Unit_Test<http://codex.wordpress.org/Theme_Unit_Test>).
>>>>> I followed up with him and verified all the errors:
>>>>>
>>>>> 1) There's a post title called "Markup: Title with Markup", but the
>>>>> export seems to have stripped the markup, or the <b> and <i>, or <strong>
>>>>> and <em> were never actually included. Modifying the post so it becomes
>>>>> "Markup: Title <i>with</i> <b>Markup</b>" now enables potential passing of
>>>>> the test. See http://demo.gamajo.com/sample/**
>>>>> 2013/01/markup-title-with-**markup/<http://demo.gamajo.com/sample/2013/01/markup-title-with-markup/>(if you change the h1 font-weight to 100, you'll see that the final word is
>>>>> indeed bold).
>>>>>
>>>>> 2) This image 404s from the import data: http://wpthemetestdata.files.
>>>>> **wordpress.com/2008/06/**dsc20050813_115856_52.jpg<http://wpthemetestdata.files.wordpress.com/2008/06/dsc20050813_115856_52.jpg>
>>>>> .
>>>>>
>>>>> 3) There's a comment by John Saddington that uses a [youtube ...]
>>>>> shortcode. I'm not sure if this is supported in JetPack, but if so, it's
>>>>> not mentioned within the comment, and if not, then perhaps a [video...]
>>>>> shortcode or oEmbeded link might be better.
>>>>>
>>>>> 4) On the Comments post, there's a 2-3 posts by Michael Novotny that
>>>>> say it is an Author comment as well. Obviously trickier if the post is
>>>>> imported and assigned to a new or existing user, but the comments seem to
>>>>> be made by someone who isn't any of the default authors, so I don't think
>>>>> it would ever match up. There's also another comment which mentions "Author
>>>>> comment" made by Alex, yet his user ID is 0, so that would never the
>>>>> relevant post author class to appear either.
>>>>>
>>>>> --
>>>>>
>>>>> I also noticed the commenters on the "Template: Comments" changed to
>>>>> be mostly folks from the 8bit team.  They're great guys, but I think it
>>>>> might be more appropriate to have the unit test data be completely
>>>>> non-commercial (remove links to companies, etc).  (No mail list drama
>>>>> y'all.  Just +1 if you like.)
>>>>>
>>>>> I believe a theme team admin will need to make these changes, so just
>>>>> wanted to pass it on.
>>>>>
>>>>> --
>>>>>
>>>>> Devin Price
>>>>> WP Theming
>>>>> @devinsays
>>>>> <http://twitter.com/devinsays>
>>>>>
>>>>> ______________________________**_________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>>>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>>>
>>>>
>>>>
>>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>

-- 
Stanko Metodiev,
Web Developer
http://metodiew.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130702/7a498bc0/attachment.html>