[theme-reviewers] Need A Final Call

[Chip Bennett]

That is absolutely not something that a Theme should be "not-approved" for,
though.


On Mon, Jan 21, 2013 at 4:10 PM, Philip M. Hofer (Frumph) <philip at frumph.net
> wrote:

>   By that ticket, the $content_width in twentytwelve would fail
>
>
>
>  *From:* Caroline Moore <calobee at gmail.com>
> *Sent:* Monday, January 21, 2013 5:39 AM
> *To:* theme-reviewers at lists.wordpress.org
> *Subject:* Re: [theme-reviewers] Need A Final Call
>
>  The ticket, for reference:
>  http://themes.trac.wordpress.org/ticket/10498
>
>
> On Monday, January 21, 2013 at 8:34 AM, Qamar Ashraf wrote:
>
>   *1. About $content_width*
>
> What is the best place for the $content_width
>
> A. Wrap $content_width definition in a callback, hooked into
> after_setup_theme - ( I am reviewing on this point )
> B. Placing $content_width outside a function
>
> *2. About IE Conditional Tags / Scripts like HTML 5 Shiv*
>
> A. - Additional scripts should not be hard-coded in the header template.
> The most appropriate way to handle them to place it in a function that
> hooks into wp_head. ( I am reviewing on this point )
> B. Can be placed directly in header.php
>
>
>
> ------------------------------
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130121/591e8b48/attachment-0001.htm>