[theme-reviewers] Need A Final Call

[Steve Kamn]

Thanks a lot Chip and Other Reviewers. This conversation is really very
helpful to me.


On Mon, Jan 21, 2013 at 6:54 PM, Chip Bennett <chip at chipbennett.net> wrote:

> Basically, anything "custom" that gets put in the document head should be
> added via callback to an appropriate hook, with wp_head being the fallback.
> For most scripts/stylesheets, the appropriate hook is going to be
> wp_enqueue_scripts. For IE-conditional scripts, this hook can be used, if
> the $GLOBALS['wp_styles']->add_data() method is used:
> http://kuttler.eu/post/wordpress-style-version-conditional-comments/
>
> Otherwise, wp_head can still be used.
>
> Regarding $content_width: all functional code in functions.php should be
> wrapped in a callback and hooked into an appropriate action - in this case,
> after_setup_theme.
>
>
> On Mon, Jan 21, 2013 at 8:41 AM, Bernard Latanowicz <
> bernard.latanowicz at gmail.com> wrote:
>
>>  Hi Qamar
>> I definitely agree with about the 2nd point. There should be a built-in
>> function for it.
>> Unfortunatelly I can't say a word about $content_width, because I feel I
>> don't understand it well.
>>
>> Regards,
>> Bernard
>>
>> W dniu 2013-01-21 14:34, Qamar Ashraf pisze:
>>
>>  Hello Admin,
>> I need a final call on the following topics as there are different views
>> by different reviewers,
>>
>>  *1. About $content_width*
>>
>>  What is the best place for the $content_width
>>
>>  A. Wrap $content_width definition in a callback, hooked into
>> after_setup_theme - ( I am reviewing on this point )
>> B. Placing $content_width outside a function
>>
>>  *2. About IE Conditional Tags / Scripts like HTML 5 Shiv*
>>
>>  A. - Additional scripts should not be hard-coded in the header
>> template. The most appropriate way to handle them to place it in a function
>> that hooks into wp_head. ( I am reviewing on this point )
>> B. Can be placed directly in header.php
>>
>>  Waiting for response.
>>
>> --
>> Regards
>> Qamar Ashraf
>> Project Manager
>> www.tutorialchip.com
>> www.freestockphotosclub.com
>> www.twunfollowapp.com
>> @lifeobject1
>>
>>
>> _______________________________________________
>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130121/6bf5e4e4/attachment.htm>