[theme-reviewers] Required Issues Found in Live Theme

[Chip Bennett]

Use your best judgement regarding whether observed required issues must be
fixed immediately, or addressed in a future revision. If the developer
disagrees, you can discuss it in-ticket, and hopefully resolve it.


On Sun, Feb 24, 2013 at 8:52 AM, Srikanth Koneru <tskk79 at gmail.com> wrote:

> If the theme author says he is fixing a major bug, should we approve the
> theme disregarding other required issues?
>
>
> On Sun, Feb 24, 2013 at 7:18 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> I you find issues, however you find them - diff-review, code review, unit
>> tests, etc. - you should note them. If the issues are at your discretion
>> minor enough, you can require them to be addressed in the next Theme
>> revision. But if they resulted from an insufficient/incomplete prior
>> review, you're probably better off marking them as required and resolving
>> as "not-approved".
>>
>> (Again at your discretion you nay hold the ticket open to allow the
>> developer to upload a revision, then continue the review in the bew ticket.)
>> On Feb 24, 2013 4:23 AM, "Greg Priday" <greg at siteorigin.com> wrote:
>>
>>> I just picked up this ticket
>>> http://themes.trac.wordpress.org/ticket/10913
>>>
>>> After giving it a full review I noticed that it's already live in the
>>> directory. For some reason it landed up in the "Previously Reviewed,
>>> Not Approved" queue.
>>>
>>> Should I approve the theme based on a diff review or require that the
>>> author fix the required issues I found?
>>>
>>> --
>>> I make free WordPress themes
>>> http://siteorigin.com
>>> http://facebook.com/SiteOrigin
>>> http://twitter.com/SiteOrigin
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130224/f31e16f9/attachment-0001.htm>