[theme-reviewers] TGM-Plugin-Activation - Theme Check

[Philip M. Hofer (Frumph)]

substitute it’s translation strings for the ones for your theme

Change the add_submenu_page to add theme_page

foreach ( $this->plugins as $plugin ) {
    if ( ! is_plugin_active( $plugin['file_path'] ) ) {                
        add_theme_page(
            $this->strings['page_title'],           // Page title
            $this->strings['menu_title'],           // Menu title
            'edit_theme_options',                   // Capability
            $this->menu,                            // Menu slug
            array( &$this, 'install_plugins_page' ) // Callback
        );
    break;
    }


This shouldn’t receive special treatment because it’s modifiable code that you can make work specifically for your theme

there are a couple other things you would need to do to make it work right for the theme repo too but those are easy



From: Bruce Wampler 
Sent: Friday, December 13, 2013 12:06 PM
To: Discussion list for WordPress theme reviewers. 
Subject: [theme-reviewers] TGM-Plugin-Activation - Theme Check

I've added TGM-Plugin-Activation to recommend plugins for my themes.


It continues to really mess up Theme Check.


First, it triggers a bunch of translation slug warnings as it uses a variable passed in.


And apparently the latest Theme Check (the one running when you upload - not the plugin which is currently not finding any problems for me - even though there are problems) is now issuing a REQUIIRED for add_theme_page. TGMPA uses add_submenu_page - again so a variable can be passed in.


Any way of getting special treatment for that plugin  as I see quite a few themes now using it since the crackdown on "plugin territory" features in themes. Kind of a pain to have to go in and understand their code to make mods to pass theme check.

Bruce Wampler



--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20131213/f9101119/attachment.html>