[theme-reviewers] Theme update failed

Tue Aug 6 18:36:43 UTC 2013

Yes, it works fine for me.

On 8/6/2013 1:31 PM, Otto wrote:
> I've updated theme check's trunk version. It's just the basic.php
> check file. Please test, tell me if that works.
>
> -Otto
>
>
> On Tue, Aug 6, 2013 at 1:26 PM, Justin Tadlock <justin at justintadlock.com> wrote:
>> I actually didn't realize it wouldn't pass theme check because we've never
>> had an issue in the past with a custom function.  If I did realize this, I
>> would've brought it up on the list beforehand.
>>
>> hybrid_body_attributes() is just a tool to solve a problem.  I realize that
>> it might not be allowed in the theme repo and theme authors don't have to
>> use the function to use the framework.  But, it would be cool if they could.
>>
>>
>> On 8/6/2013 1:05 PM, Otto wrote:
>>> On Tue, Aug 6, 2013 at 11:47 AM, Justin Tadlock
>>> <justin at justintadlock.com> wrote:
>>>> I actually added in a new function called hybrid_body_attributes().  The
>>>> idea is to get a jump start on the following ticket and allow for devs to
>>>> filter attributes other than the class.  The use of the 'body_class' hook
>>>> (the important part) still works when using this function.
>>>> http://core.trac.wordpress.org/ticket/21766
>>> Okay. So, how do you propose that we detect that your function calls
>>> body_class in some automated fashion for Theme Check?
>>>
>>> At this point, I'm kind of inclined to say, guess what, all Hybrid
>>> based themes just failed Theme Check and can no longer go into the
>>> repository. Well, ain't that a bummer?
>>>
>>> We're checking for function calls to make sure people don't forget
>>> them. Do you seriously expect the generic Theme Check plugin to have
>>> special cases in it for every framework available?
>>>
>>> Proposal: Instead of including body_class in your function call, why
>>> not leave it alone and add on another function call. Like so:
>>>
>>> <body <?php body_class(); ?> <?php hybrid_body_attributes(); ?>>
>>>
>>> -Otto
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers