[theme-reviewers] Printing JavaScript in footer

[Harish]

Hi,

 

I have seen many premium themes doing this. Not a good practise so I would not recommend it. 

 

 

 

Regards,

Harish Chouhan

 

Visit me at -  <http://www.harishchouhan.com/> www.harishchouhan.com 
Phone: +91-9833661410 | Email:  <mailto:me at harishchouhan.com> me at harishchouhan.com 

 

From: theme-reviewers [mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Ola Laczek
Sent: Sat 03 August 13 09:16 PM
To: theme-reviewers at lists.wordpress.org
Subject: [theme-reviewers] Printing JavaScript in footer

 

Hello!

 

I'm reviewing a theme that prints javascript in the footer from functions.php like this:

 

add_action('wp_footer', 'flex_init');

function flex_init() {

     echo '<script type="text/javascript">

    jQuery(document).ready(function() {

        jQuery("#slider").flexslider();

     });

     </script>';

}

 

Is this ok, or should I tell this person to create separate javascript file, put this code there and enqueue like other scripts?

 

 

Best regards,
Ola Łączek

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130803/701d499f/attachment-0001.html>