[theme-reviewers] Clarification

Sun Sep 23 03:41:18 UTC 2012

Okay, was this person denied inclusion into the repo and still has it in there?   Or are you just wanting to not give them a chance to fix it and just nip it in the bud completely?

- Phil

From: Chip Bennett 
Sent: Saturday, September 22, 2012 8:39 PM
To: theme-reviewers at lists.wordpress.org 
Subject: Re: [theme-reviewers] Clarification

No, that would be obfuscated code. 

Kill code usually does just that: it invokes die( 'some message about the Theme not working because the footer was modified' ).

Obfuscated code is one thing, and bad enough on its own rights. But kill code actually prevents the Theme from working, based on some hash or string comparison, to ensure that the footer links (or the entire footer) isn't modified.

Chip

On Sat, Sep 22, 2012 at 10:32 PM, Daniel Fenn <danielx386 at gmail.com> wrote:

  When you say kill code, you mean putting the code in base64?

  On Sun, Sep 23, 2012 at 6:22 AM, Chip Bennett <chip at chipbennett.net> wrote:
  > In this case, it is because the submitter is distributing Themes with spammy
  > (not merely "sponsored") links, distributes those Themes under a
  > non-GPL-compatible license, and includes kill-code in the Theme to prevent
  > modification.
  >
  >
  > On Sat, Sep 22, 2012 at 9:26 AM, Philip M. Hofer (Frumph)
  > <philip at frumph.net> wrote:
  >>
  >> Is banning from submitting to theme-trac for people not complying or is it
  >> for people who are being intolerably difficult?
  >>
  >>
  >>
  >> From: Chip Bennett
  >> Sent: Saturday, September 22, 2012 4:07 AM
  >> To: theme-reviewers at lists.wordpress.org
  >> Subject: Re: [theme-reviewers] Clarification
  >>
  >> Let me go a step farther: Otto, please ban "Smthemes" from submitting to
  >> Theme-Trac. We want absolutely nothing to do with developers who put this
  >> garbage in their Themes:
  >>
  >>
  >> <?php /*
  >> All links in the tag <div class='smthemes'> are attribution of the theme
  >> developers and should remain intact.
  >> It's protected by Creative Commons License
  >> (http://creativecommons.org/licenses/by/3.0/).
  >> Warning! Your site will not be able to work if these links are edited or
  >> deleted.
  >> You can buy this theme without footer links online at
  >> http://smthemes.com/buy/animepress/
  >> */ ?>
  >> <div class='smthemes'>Designed by <a
  >> href='http://smthemes.com/category/food/' target='_blank'>Free WordPress
  >> food themes</a>, thanks to: <a href='http://wpdis.co/' target='_blank'>Free
  >> WordPress magazine themes</a>, <a href='http://lizardthemes.com'
  >> target='_blank'>LizardThemes.com</a> and <a href='http://fthe.me'
  >> target='_blank'>FThe.me</a></div>
  >>
  >>
  >> Thanks,
  >>
  >> Chip
  >>
  >> On Sat, Sep 22, 2012 at 5:51 AM, Chip Bennett <chip at chipbennett.net>
  >> wrote:
  >>>
  >>> I'm guessing you're referring to this ticket?
  >>> http://themes.trac.wordpress.org/ticket/9299
  >>>
  >>> I've run into this site before. Here's what I said then:
  >>> http://themes.trac.wordpress.org/ticket/7420
  >>>
  >>>
  >>> "For future reference, indicated Author URI/Theme URI site distributes
  >>> Themes under a non-GPL-compatible license (i.e. link-removal purchase
  >>> license). Themes from such sites will not be accepted for hosting in the
  >>> repository."
  >>>
  >>>
  >>> It appears that this statement is still accurate:
  >>> http://smthemes.com/terms-of-services/
  >>> and also:
  >>> http://smthemes.com/
  >>>
  >>>
  >>> Welcome to SMThemes.com. We offer a wide variety of free WordPress
  >>> themes. You can download and use all our templates for free, or purchase
  >>> free links version of template
  >>>
  >>>
  >>> The site still mentions paid link-removal, and themes are CC-licensed.
  >>>
  >>> The sponsored-Themes prohibition is a WPORG repository policy. There's
  >>> nothing inherently contra GPL to put paid links in a Theme. What *is* contra
  >>> GPL is to require a paid license for the end-user to remove those links, and
  >>> to distribute that Theme under CC-By.
  >>>
  >>> So yes: this ticket, and any other ticket submitted for a Theme
  >>> affiliated with this site, should be not-approved.
  >>>
  >>> Thanks,
  >>>
  >>> Chip
  >>>
  >>> On Sat, Sep 22, 2012 at 4:31 AM, Vicky Arulsingam
  >>> <vicky.arulsingam at gmail.com> wrote:
  >>>>
  >>>> The author url of the theme I'm reviewing contains this page:
  >>>> http://smthemes.com/links/
  >>>> This isn't acceptable for the repository?
  >>>>
  >>>> The theme itself doesn't contain any sponsored links
  >>>>
  >>>> -----
  >>>> Vicky Arulsingam
  >>>>
  >>>>
  >>>> _______________________________________________
  >>>> theme-reviewers mailing list
  >>>> theme-reviewers at lists.wordpress.org
  >>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
  >>>>
  >>>
  >>
  >>
  >>
  >> ________________________________
  >> _______________________________________________
  >> theme-reviewers mailing list
  >> theme-reviewers at lists.wordpress.org
  >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
  >>
  >>
  >> _______________________________________________
  >> theme-reviewers mailing list
  >> theme-reviewers at lists.wordpress.org
  >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
  >>
  >
  >
  > _______________________________________________
  > theme-reviewers mailing list
  > theme-reviewers at lists.wordpress.org
  > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
  >
  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers

--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120922/f839b4c5/attachment-0001.htm>