[theme-reviewers] pluggable functions

Kirk Wight kwight at kwight.ca
Sat Oct 27 19:17:53 UTC 2012


I'm reviewing a theme that has made all functions in functions.php
pluggable, including those on hooks. From what I understand, this won't
break anything, but doesn't feel very "best practice"-y (anything on a hook
can just be removed from the hook, making the pluggable code un-necessary).

The theme was already approved, but I prefer to encourage the best
practice; perhaps a "fix in next release" note is appropriate, rather than
blocking approval?..
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20121027/e18586ad/attachment.htm>

More information about the theme-reviewers mailing list