[theme-reviewers] Page navigation links with excerpts?

[Chip Bennett]

Re: wp_link_pages()

We should defer to the developer's design aesthetic wherever possible. As
long as wp_link_pages() is output in the single-post view, it should be
fine.

Re: internationalization

The example you posted would be almost unintelligible to some translators,
the way it is split apart. For correct implementation/best-practice, see
Otto's post:
http://ottopress.com/2012/internationalization-youre-probably-doing-it-wrong/

I would require correct implementation (i.e. using sprintf() in this case),
with an example for how to implement.

Thanks,

Chip

On Sat, Mar 17, 2012 at 3:03 PM, Konstantin Obenland <obenland at gmx.de>wrote:

> Hello,
>
> it's me again, with yet another question. :/
>
> I'd really appreciate a second opinion on this ticket (
> http://themes.trac.wordpress.org/ticket/6868) if anyone gets a chance. Am
> I being to strict here?
>
> Can Themes that display the excerpt in index pages omit the usage of
> wp_link_pages()?
>
> And what about this best practice:
> Use format strings instead of string concatenation — sprintf(__('Replace
> %1$s with %2$s'), $a, $b); is always better than __('Replace ').$a.__('
> with ').$b;
>
> Would this be required, recommended or optional?
> Example:
> <?php _e( 'This is a gallery about', 'esplanade' ); ?>
> <a href="<?php the_permalink(); ?>" title="<?php the_title_attribute();
> ?>" rel="bookmark"><?php the_title(); ?></a>
> <?php _e( 'and contains', 'esplanade'); ?>
> <?php echo count( get_posts( array( 'numberposts' => -1, 'post_type' =>
> 'attachment', 'post_mime_type' => 'image', 'post_parent' => get_the_ID() )
> ) ); ?>
> <?php _e( 'images', 'esplanade'); ?>.
>
> Thanks for your patience,
> Konstantin
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120317/41370858/attachment.htm>