[theme-reviewers] Is this now a requirement for submittedthemes?

[Edward Caissie]

I wrote this example a few months ago: https://gist.github.com/1410493 ...
I use it as a base for most of my themes.

Although some example "callback" functions could be added somewhere (codex,
make-themes, etc.), the basic functionality of `wp_title` can produce an
adequate HTML title on its own ... filtering its output, IMHO, is more an
author's prerogative than anything else. IF we were to have a
"cookie-cutter" example, I would put forward it should be submitted to
core-trac as an enhancement to `wp-title`.


Cais.


On Tue, Jul 3, 2012 at 9:12 AM, Konstantin Obenland
<konstantin at obenland.it>wrote:

> Does this count?
>
> http://wordpress.stackexchange.com/questions/32622/when-calling-wp-title-do-you-have-to-create-some-kind-of-title-php-file
>
> Konstantin
>
> On 03.07.2012, at 15:02, Philip M. Hofer (Frumph) wrote:
>
>   Is there a post on example functions for callback for this that is
> approved by the WPTRT ?
>
>
>
>  *From:* Edward Caissie <edward.caissie at gmail.com>
> *Sent:* Tuesday, July 03, 2012 5:46 AM
> *To:* theme-reviewers at lists.wordpress.org
> *Subject:* Re: [theme-reviewers] Is this now a requirement for
> submittedthemes?
>
> The "best practice" use of modifying the `wp_title` output via a filter
> call is required, but mostly as a "best practice" and to insure it "plays
> nice" with plugins, specifically the SEO varieties.
> IF the theme has already been approved, then obviously any new updates
> should include the more correct best practice method; if this is the only
> "fix" being added in the submission, I would also imagine it would be a
> very quick diff review and resolved as approved ... personally, I would
> simply write the modification and submit it now.
>
>
> Cais.
>
>
> On Tue, Jul 3, 2012 at 7:27 AM, Shinra Web Holdings <
> shinrawebholdings at gmail.com> wrote:
>
>> Yes, it's required now. Plugin authors were getting mad that they
>> couldn't fully change the title (since bloginfo('name') was typically
>> hardcoded in, so now it is required to use the wp_title filter. I put a
>> function on the codex page that you can pretty much take verbatim.
>>
>>
>> On Tue, Jul 3, 2012 at 4:38 AM, Konstantin Obenland <
>> konstantin at obenland.it> wrote:
>>
>>> I don't know how others see it, but I would't consider it urgent enough
>>> for immediate action. Just have it fixed the next time you get around to
>>> submitting an update. :)
>>>
>>> Konstantin
>>>
>>> On 03.07.2012, at 11:29, esmi at quirm dot net wrote:
>>>
>>> > on 03/07/2012 08:00 Konstantin Obenland said the following:
>>> >> Your Theme was first approved almost two years ago and a lot has
>>> >> changed since then. If you want to stay on top of all changes, you
>>> >> might want to check out the Theme Review Codex page regularly and/or
>>> >> weigh in on the discussions we have on make.wordpress.org/themes for
>>> >> new and changing requirements.
>>> >
>>> > I do try to do both but somehow this slipped past me. :-) Are you ok
>>> for the theme to be released on the Repo "as is"? Or would you prefer me to
>>> re-submit an amended version?  I have 3 other themes I'm updating and I
>>> don't want to give you guys even more work if it can be avoided.
>>> >
>>> > Mel
>>> > --
>>> > http://quirm.net
>>> > http://blackwidows.co.uk
>>> >
>>> >
>>> > _______________________________________________
>>> > theme-reviewers mailing list
>>> > theme-reviewers at lists.wordpress.org
>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> ------------------------------
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>  _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120703/190dad9a/attachment.htm>