[theme-reviewers] Prefixing theme specific actions and filters

[Chip Bennett]

I would hold the ticket open, and ask them to fix and re-upload.

Out of curiosity: what is the naming convention for the rest of the
template action hooks in Toolbox?

Chip

On Tue, Jan 10, 2012 at 8:28 AM, George Mamadashvili <
georgemamadashvili at gmail.com> wrote:

> I was checking changes in Toolbox theme and noticed that they added two
> new hooks that aren't prefix, here's diff
> http://themes.trac.wordpress.org/changeset?old_path=/toolbox/1.3&new_path=/toolbox/1.4
>
> Maybe we should add suggestion to theme ticket for future release
>
>
> On Tue, Jan 10, 2012 at 6:19 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> Yes. Basically, anything that is/can be in a public namespace should be
>> uniquely prefixed.
>>
>> Thus, a custom action, e.g. 'post_after', should be prefixed, i.e. as
>> 'theme_slug_post_after'. Likewise (and more importantly) with filters.
>>
>> Chip
>>
>> On Tue, Jan 10, 2012 at 8:08 AM, George Mamadashvili <
>> georgemamadashvili at gmail.com> wrote:
>>
>>> Shouldn't theme specific actions and filters be prefixed?
>>>
>>> Thanks
>>>
>>> George
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120110/e2399164/attachment.htm>