[theme-reviewers] FB Like button

[Paul Appleyard]

Yup, that's what I'm doing, for that reason and a whole bunch more. He 
actually has quite a few good ideas in it, just needs to fix a few 
things up..

Paul

On 21/02/2012 8:05 AM, Otto wrote:
> It may be accidental or by design, but regardless it shouldn't have an
> AppID in the theme. I'd just disapprove it and tell the author to
> remove that appid.
>
> -Otto
>
>
>
> On Mon, Feb 20, 2012 at 1:46 AM, Emil Uzelac<emil at themeid.com>  wrote:
>> I am not 100% familiar
>> with http://connect.facebook.net/en_US/all.js#xfbml=1&appId=233928906624944
>> @Otto will be much better person for something like that. Not sure why he
>> didn't go with this only http://connect.facebook.net/en_US/all.js#xfbml=1
>> you can ask this in trac.
>>
>> Emil
>>
>> On Mon, Feb 20, 2012 at 1:40 AM, Paul Appleyard<paul at spacecat.com>  wrote:
>>> Ok, well the author has an option in settings for turning 'social media'
>>> buttons on or off; here's the raw like button code:
>>>
>>> <script>(function(d, s, id) {
>>>
>>>    var js, fjs = d.getElementsByTagName(s)[0];
>>>
>>>    if (d.getElementById(id)) {return;}
>>>
>>>    js = d.createElement(s); js.id = id;
>>>
>>>    js.src =
>>> "//connect.facebook.net/en_US/all.js#xfbml=1&appId=233928906624944";
>>>
>>>    fjs.parentNode.insertBefore(js, fjs);
>>>
>>> }(document, 'script', 'facebook-jssdk'));</script>
>>>
>>>
>>> .. as you can see he uses his own appId (233928906624944) It's fairly
>>> innocuous although the author could use it to track theme use. The button
>>> will work without the appId parameter in place.
>>>
>>>
>>> Paul
>>>
>>> On 20/02/2012 3:15 PM, Emil Uzelac wrote:
>>>
>>> Paul,
>>>
>>> Not sure if this is "out-and-out evil" and if something like this should
>>> be pushed over to plugin.
>>>
>>> What you got in loop-front.php is very much standard JS code for FB Like
>>> Button and it's also available on their dev
>>> page http://developers.facebook.com/docs/guides/web/. This was a straight-up
>>> paste and nothing has been changed from what I could see.
>>>
>>> Should that be in Theme Options maybe, well it could.
>>>
>>> Emil
>>>
>>> On Sun, Feb 19, 2012 at 10:58 PM, Paul Appleyard<paul at spacecat.com>
>>> wrote:
>>>> Just after a point of order; an author has inserted Facebook LIKE button
>>>> JS code into loop-front.php, but has his OWN appId in the code; obviously
>>>> this is unacceptable, but is it out-and-out evil, calling for a complete
>>>> blackballing of the author, public humiliation etc.
>>>>
>>>> This is my second review, and my impression is that this sort of
>>>> functionality kind of belongs to plugins, and that there should at least be
>>>> an option for the theme user to add their own app id.
>>>>
>>>> Paul
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers