[theme-reviewers] error suppression

[Otto]

Never mind, I see it now.

Error suppression using @ just stops the PHP error handler from being
called on an error. If you have custom error handlers, like the debug
bar does, then those still get called.

Info here: http://php.net/manual/en/function.set-error-handler.php
And here: http://php.net/manual/en/language.operators.errorcontrol.php

-Otto



On Mon, Feb 13, 2012 at 9:50 AM, Otto <otto at ottodestruct.com> wrote:
> I think he has a point in this case. The error is explicitly
> suppressed, so I can't see what the reviewer is doing to make it
> appear.
>
> Appending an @ in front a line deliberately turns off errors, so how
> is he seeing it in this case?
>
> -Otto
>
>
>
> On Mon, Feb 13, 2012 at 8:24 AM, Chip Bennett <chip at chipbennett.net> wrote:
>> Suppressing printing of errors/notices is not a sufficient substitution for
>> eliminating those errors/notices. The guidelines require that Themes be free
>> of PHP notices/errors/warnings, whether those notices/errors/warnings are
>> printed or not.
>>
>> Chip
>>
>> On Mon, Feb 13, 2012 at 8:13 AM, Kirk Wight <kwight at kwight.ca> wrote:
>>>
>>> Do we make any allowances for Debug Bar errors if error suppression has
>>> been implemented for the errors in question?
>>>
>>> In this theme (https://themes.trac.wordpress.org/ticket/6095), Debug Bar
>>> will throw an error, even though error suppression has been used to account
>>> for E_NOTICE and E_WARNING notices. Without knowing anything about coding
>>> with error suppression, it feels odd to me (I guess I see submitted themes
>>> using it to get around errors, rather than dealing with them, but I don't
>>> think that's the situation in this case).
>>>
>>> What do people think?
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>