[theme-reviewers] About Text Domain Issues

[George Mamadashvili]

Not sure if this can be only reason to not approve theme, but Theme Review
codex says, that themes are required to use  theme-slug as textdomain for
translation.

On Sat, Feb 11, 2012 at 4:25 PM, Qamar Ashraf <life.object at gmail.com> wrote:

> Thanks Caroline
>
>
> On Sat, Feb 11, 2012 at 5:21 PM, Caroline Moore <calobee at gmail.com> wrote:
>
>> If there are only one or two small issues, I usually approve but make a
>> note of them, and ask that they be fixed in the next release. Others have
>> done this when reviewing my themes too.
>>
>> Sent from my iPhone
>>
>> On Feb 11, 2012, at 7:16 AM, Qamar Ashraf <life.object at gmail.com> wrote:
>>
>> Hello,
>> I am currently reviewing a theme so want to clarify my concept before
>> marking it "approved". Theme Check plugin has given recommendations to fix
>> some text domain issues. So can i approve a theme with the recommended text
>> domain issues.
>>
>> Example is:
>>
>> RECOMMENDED: Text domain problems in *abc.php*. You have not included a
>> text domain!
>> Line 91: $title = sprintf( __('%s (Pending)'), $item->title );
>>
>> Take Care
>>
>> --
>> Regards
>> Qamar Ashraf
>> Project Manager
>> www.tutorialchip.com
>> www.freestockphotosclub.com
>> www.twunfollowapp.com
>> @lifeobject1
>>
>>  _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
> --
> Regards
> Qamar Ashraf
> Project Manager
> www.tutorialchip.com
> www.freestockphotosclub.com
> www.twunfollowapp.com
> @lifeobject1
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120211/a41f706a/attachment.htm>