[theme-reviewers] Baris Theme
Justin Tadlock
justin at justintadlock.com
Mon Dec 17 04:57:34 UTC 2012
His use of locate_template() is incorrect in that theme. But,
get_template_part() would also be incorrect. He's not loading any
templates in this case. He's loading non-template files.
Here's a reference tutorial on how to load templates and other files in
WordPress themes:
http://justintadlock.com/archives/2010/11/17/how-to-load-files-within-wordpress-themes
On 12/16/2012 9:01 PM, Malvouz wrote:
> I already review this ticket
> http://themes.trac.wordpress.org/ticket/10051
>
> /**
> *Wordpress Setup [OK]*
> *License **[OK]*
> *Credit Links **[OK]*
> *Theme Name **[OK]*
> *Screenshot **[OK]*
> ***/*
> *
> *
> *CODE*
> header.php,footer.php, function.php and style.css are GOOD.
> *
> *
> *FILE INCLUDES*
> /He use locate_template rather than get_template_part(); is it ok?/
> /
> /
> *THEME UNIT TEST*
> 1. There is no error, warning or notices for index.php
> 2. No error in Deprecated Calls Plugin.
> 3. Custom Themes is GOOD.
> - no error, warning, and notice. Button save and restore to default
> are work.
> 4. Custom Header, background and custom menu are GOOD.
> 5. Widgets are GOOD.
>
> *General Test*
> W3C Validation: Since the Theme URL doesnt exist, I could not generate.
>
>
> ---
> *Resolution*
> /1. Theme URI doesnt exist./
> /2. locate_template rather than get_template_part ?/
>
>
> On Sun, Dec 16, 2012 at 10:01 PM, Malvouz <malvouz at gmail.com
> <mailto:malvouz at gmail.com>> wrote:
>
> Thank You..
>
>
> On Sun, Dec 16, 2012 at 10:00 PM, Srikanth Koneru
> <tskk79 at gmail.com <mailto:tskk79 at gmail.com>> wrote:
>
> http://www.chipbennett.net/2011/04/20/a-guide-to-reviewing-themes-for-the-wordpress-theme-repository/
>
>
>
>
> On Sun, Dec 16, 2012 at 8:28 PM, Malvouz <malvouz at gmail.com
> <mailto:malvouz at gmail.com>> wrote:
>
> Hi Emil,
>
> I got your comment and I am assigned
> http://themes.trac.wordpress.org/ticket/10051
>
> Nevertheless, do you have any tutorial or guidance to
> review a theme? Because I do not know where I have to start.
>
> Thank You Emil.
>
>
> On Fri, Dec 14, 2012 at 1:23 PM, Malvouz
> <malvouz at gmail.com <mailto:malvouz at gmail.com>> wrote:
>
> Hi Emil,
>
> I already comment on those link.
>
> Thanks,
> Malvouz.
>
>
> On Fri, Dec 14, 2012 at 10:45 AM, Emil Uzelac
> <emil at themeid.com <mailto:emil at themeid.com>> wrote:
>
> Hi,
>
> All from
> http://make.wordpress.org/themes/about/trac-ticket-request-queue/trac-ticket-request-queue-nov-2012/ was
> just assigned, some of the comments
> were held in moderation.
>
> Thanks,
> Emil
>
>
> On Thu, Dec 13, 2012 at 9:38 PM, Malvouz
> <malvouz at gmail.com <mailto:malvouz at gmail.com>> wrote:
>
> Hi Emil,
>
> The Day before yesterday, I already follow
> those instruction.
>
> At point 4,
> Go to the Trac Ticket Request Queue
> <http://make.wordpress.org/themes/about/trac-ticket-request-queue/> Page,
> and leave a comment asking to be assigned a
> Theme from the Theme Review Trac Queue
> <https://themes.trac.wordpress.org/query?status=%21closed&order=priority&report=9&owner=>.
> Be sure to *include your wordpress.org
> <http://wordpress.org> username with your
> request*, so that a ticket can be assigned to you.
>
> I could not found comment field on
> http://make.wordpress.org/themes/about/trac-ticket-request-queue/
>
>
> On Fri, Dec 14, 2012 at 10:29 AM, Emil Uzelac
> <emil at themeid.com <mailto:emil at themeid.com>>
> wrote:
>
> http://make.wordpress.org/themes/about/how-to-join-wptrt/
>
>
> On Thu, Dec 13, 2012 at 9:26 PM, Malvouz
> <malvouz at gmail.com
> <mailto:malvouz at gmail.com>> wrote:
>
> Hi Otto,
>
> How to become reviewer?
>
>
> On Thu, Dec 13, 2012 at 1:30 PM, Otto
> <otto at ottodestruct.com
> <mailto:otto at ottodestruct.com>> wrote:
>
> On Wed, Dec 12, 2012 at 9:34 PM,
> Malvouz <malvouz at gmail.com
> <mailto:malvouz at gmail.com>> wrote:
> > Dear Theme Reviewers,
> >
> > I uploaded my theme 2 days ago
> and still not getting review.
> > This is my theme
> http://themes.trac.wordpress.org/ticket/10313
> >
> > Thank You So Much,
> > Malvouz
>
> The current expected turnaround is
> months, not days.
>
> We need more active reviewers.
> Feel free to pitch in if you think
> you can help!
>
> -Otto
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org <mailto:theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> <mailto:theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> <mailto:theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> <mailto:theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> <mailto:theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> <mailto:theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> <mailto:theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20121216/087b44ac/attachment-0001.htm>
More information about the theme-reviewers
mailing list