[theme-reviewers] unable to upload please advice

Otto otto at ottodestruct.com
Thu Aug 23 14:19:49 UTC 2012


On Thu, Aug 23, 2012 at 9:01 AM, Chip Bennett <chip at chipbennett.net> wrote:
> The guideline states: "Themes must not support backward compatibility for
> more than two major WordPress versions (currently: WordPress 3.2)"
>
> There is no possible, logical way that you can conclude that version 3.2 is
> MORE THAN TWO versions prior to the current version, which is 3.4.

BTW, the guideline doesn't say "prior to the current version". It says
"more than two major WordPress versions", period, full-stop.

Two major WordPress versions are 3.4 and 3.3.

This affects more than just add_contextual_help, BTW. From the theme-check:

array( 'screen_layout' => '$current_screen->render_screen_layout()', '3.3' ),
array( 'screen_options' =>
'$current_screen->render_per_page_options()', '3.3' ),
array( 'screen_meta' => ' $current_screen->render_screen_meta()', '3.3' ),
array( 'media_upload_image' => 'wp_media_upload_handler()', '3.3' ),
array( 'media_upload_audio' => 'wp_media_upload_handler()', '3.3' ),
array( 'media_upload_video' => 'wp_media_upload_handler()', '3.3' ),
array( 'media_upload_file' => 'wp_media_upload_handler()', '3.3' ),
array( 'type_url_form_image' => 'wp_media_insert_url_form( \'image\'
)', '3.3' ),
array( 'type_url_form_audio' => 'wp_media_insert_url_form( \'audio\'
)', '3.3' ),
array( 'type_url_form_video' => 'wp_media_insert_url_form( \'video\'
)', '3.3' ),
array( 'type_url_form_file' => 'wp_media_insert_url_form( \'file\' )', '3.3' ),
array( 'add_contextual_help' =>
'get_current_screen()->add_help_tab()', '3.3' ),


All of these are marked as REQUIRED because they were deprecated in
3.3. So what you're saying is that all of these should actually be
allowed but are currently being blocked.

And that's fine, no argument on that point. Just fix the guideline to
state that 3.2 is okay, that we actually allow THREE versions of
support.

-Otto


More information about the theme-reviewers mailing list