[theme-reviewers] [WordPress Themes] #8830: THEME: PageLines - 1.2.3

[Emil Uzelac]

This would be definitely something we can discuss, placeholder such as
http://placehold.it<http://placehold.it/1200x300&text=Specify+a+url+using+the+imageurl=%22%22+attribute!>
should't
be something we need to forbid, service is pretty known and wide used by
many developers around and they don't pose any treats to users. Well like
Daniel said, just personal opinion that's all :)

Emil

On Tue, Jul 31, 2012 at 8:52 PM, Daniel Tara <contact at onedesigns.com> wrote:

> I don't see anything wrong with the screenshot of this theme. Other that
> the page scroll is a bit in offset and I believe that pretty easy to add to
> trivial to request a new screenshot. Just my opinion.
>
> Daniel
>
> On Aug 1, 2012, at 4:06 AM, Trent Lapinski wrote:
>
> Thanks Otto. I've approved it and noted it for their next release.
>
>   --Trent Lapinski
> =============
> CEO of CyberChimps LLC
> trent at cyberchimps.com
> Mobile (714) 904-4280
> Twitter @trentlapinski
> http://CyberChimps.com
>
> On Jul 31, 2012, at 6:00 PM, Otto <otto at ottodestruct.com> wrote:
>
> Placehold.it isn't objectionable enough to reject, but they should build
> it in for the next version.
>
> Sorry for the brevity and typos, sent from my phone.
> On Jul 31, 2012 7:53 PM, "Trent Lapinski" <trent at cyberchimps.com> wrote:
>
>> Hey guys,
>>
>> Was reviewing the PageLines theme when I came across a 3rd party image
>> for a fallback image.
>>
>> I wanted to confirm whether or not this is allowed by more seasoned
>> reviewers?
>>
>> Can I approve this version and let them address it in their next release
>> or do I need to not-approve this and have them submit a new version without
>> the the 3rd party image?
>>
>> Thanks!
>>
>>   --Trent Lapinski
>> =============
>> CEO of CyberChimps LLC
>> trent at cyberchimps.com
>> Mobile (714) 904-4280
>> Twitter @trentlapinski
>> http://CyberChimps.com <http://cyberchimps.com/>
>>
>> On Jul 31, 2012, at 5:43 PM, WordPress Themes <
>> theme-reviewers at lists.wordpress.org> wrote:
>>
>> #8830: THEME: PageLines - 1.2.3
>> ----------------------------+--------------------------
>> Reporter:  arpowers         |       Owner:  applextrent
>>    Type:  theme            |      Status:  assigned
>> Priority:  major            |  Resolution:
>> Keywords:  theme-pagelines  |
>> ----------------------------+--------------------------
>>
>> Comment (by applextrent):
>>
>> Differential review only.
>>
>> - For class.shortcodes.php what is the purpose of?
>>
>> http://placehold.it/1200x300&text=Specify+a+url+using+the+imageurl=&quot;&quot;+attribute!<http://placehold.it/1200x300&text=Specify+a+url+using+the+imageurl=%22%22+attribute!>
>>
>> "Themes are required to include within the Theme all images, scripts, and
>> other bundled resources. Such resources must not be "hotlinked" from a
>> third-party site."
>>
>> I don't really see why you need to be loading a default image /
>> placeholder that isn't part of the theme.
>>
>> - Your screenshot does not match the defaults for your theme. The menu
>> is not cropped correctly, the "Why You'll Love PageLines" does not even
>> appear to be a part of the theme, and the three color icons do not match
>> the black and white icons that come with the theme. I checked this latest
>> version to see if you updated the icons to those colored ones but you
>> haven't.
>>
>> According to the review guidelines, Your screenshot "should be a
>> "reasonable facsimile" of the Theme after it is initially activated with
>> default options.'"
>>
>> Please provide a more accurate screenshot of your theme in your next
>> release.
>>
>> Please wait while I consult with other team review members if I can
>> approve this update or not.
>>
>> --
>> Ticket URL: <http://themes.trac.wordpress.org/ticket/8830#comment:2>
>> WordPress Themes <http://themes.trac.wordpress.org/>
>> WordPress.org <http://wordpress.org/> Theme Directory Reviews
>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120731/10c66704/attachment.htm>