[theme-reviewers] #7076 - My first review - some questions

Mon Apr 9 20:39:07 UTC 2012

Thanks for the tips, Chip.
I have just written my comments in the Ticket. What's next?
Lucia

>
>
> Today's Topics:
>
>    1. Inserting posts on activation (Konstantin Obenland)
>    2. Re: Inserting posts on activation (Chip Bennett)
>    3. Re: Inserting posts on activation (Thomas Scholz)
>    4. #7076 - My first review - some questions (Lucia Dossin)
>    5. Re: #7076 - My first review - some questions (Chip Bennett)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sat, 7 Apr 2012 18:00:34 +0200
> From: Konstantin Obenland <konstantin at obenland.it>
> Subject: [theme-reviewers] Inserting posts on activation
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <78C052A5-73DC-4E7B-8DBB-49B1C60DFF97 at obenland.it>
> Content-Type: text/plain; charset="us-ascii"
>
> Are Themes allowed to publish a page on activation?
>
> Thanks,
> Konstantin
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/e3d2edbf/attachment-0001.htm>
>
> ------------------------------
>
> Message: 2
> Date: Sat, 7 Apr 2012 11:22:44 -0500
> From: Chip Bennett <chip at chipbennett.net>
> Subject: Re: [theme-reviewers] Inserting posts on activation
> To: theme-reviewers at lists.wordpress.org
> Message-ID:
> 	<CAPdLKqc5iqi7=Eg-pRdEmqCy_kjYopMH=e4T_USKS4jwBEHO7A at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> They will be able to create a page with the new 3.4 Front Page
> functionality, whereby a Theme can declare a static Front Page.
>
> That's something that we'll need to consider, with the upcoming guidelines
> revisions.
>
> Thanks,
>
> Chip
>
> On Sat, Apr 7, 2012 at 11:00 AM, Konstantin Obenland
> <konstantin at obenland.it
>> wrote:
>
>> Are Themes allowed to publish a page on
>> activation<http://themes.trac.wordpress.org/browser/cross-fitness-workout/1.1/functions.php?rev=19898#L52>
>> ?
>>
>> Thanks,
>> Konstantin
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/247387a8/attachment-0001.htm>
>
> ------------------------------
>
> Message: 3
> Date: Sat, 07 Apr 2012 18:34:52 +0200
> From: "Thomas Scholz" <thomas.scholz at gmail.com>
> Subject: Re: [theme-reviewers] Inserting posts on activation
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <op.wceloeq1qsyxj4 at fqdn.toscho.de>
> Content-Type: text/plain; charset=windows-1252; format=flowed;
> 	delsp=yes
>
> Konstantin Obenland
>
>> Are Themes allowed to publish a page on activation?
>
> I don?t think this a good idea. Imagine some trying out a dozen themes ?
>
> In this special case it should not be allowed. 'Profile' is not translated
> (in German it is a plural, meaning 'profiles'), the page content is
> missing translation too, and the 'post author' may not even exist (you can
> delete user 1). Plus, the page is published immediately for no obvious
> reason.
>
> Thomas Scholz
>
>
> ------------------------------
>
> Message: 4
> Date: Sat, 07 Apr 2012 19:32:22 +0200
> From: Lucia Dossin <lucia at fiveblackcats.com>
> Subject: [theme-reviewers] #7076 - My first review - some questions
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <4F807A26.7040102 at fiveblackcats.com>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> Hi there,
> I just finished my first review (ticket #7076, Zenon Lite) and I'd like
> to check some points with you, the veterans, before I proceed ;) .
>
> Policy Requirements
> ------------------
> - must all icons/graphics have an explicit license or is a general info
> about License in the readme.txt enough?
> - theme has a folder called ie6 where there's a js file with messages
> asking the user to upgrade their browser. There's no option to disable
> that in the Admin interface. Is that ok?
> - theme has an about.php file, inside admin folder, where theme author
> lists his facebook, twitter, flickr pages and his website as well. He also
> displays there a comparison table + link to the Pro version of this Theme.
> is that ok?
> -Theme comes with 3 font options. They are licenced under SIL Open Font
> License (OFL), I guess that's ok, right?
>
>
> Theme Check Results
> ------------------
> Theme passed the tests and the following result messages were displayed.
> (1)RECOMMENDED: No reference to add_editor_style() was found in the theme.
> It is recommended that the theme implement editor styling, so as to make
> the editor content match the resulting post output in the theme, for a
> better user experience.
> ->My question: should I mention that in the review?
>
>   (2)RECOMMENDED: No reference to add_custom_image_header was found in the
> theme. It is recommended that the theme implement this functionality if
> using an image for the header.
> ->My comment on that: No image for the header, so I guess it's ok.
>
> Three more INFO notices were displayed.
>
>
> Theme Unit Tests
> ----------------
> - If one of the options provided by Theme is checked (Enable Sticky Menu),
> Blog title rotates 90 degrees as I scroll (Firefox 11). Seems to be a bug.
> This options is checked by default.
>
> - Post with no title links to error 404 page.
>
> - Long menu doesn't 'break' the site layout but some menu items are
> displayed out of the menu bar. No mention to menu items limit was found in
> the readme.txt.
>
> - Validation: theme did not pass markup validation, got 36 errors. The
> first error refers to nested ul tags (they seem right, though).
>
>
>
> Hope to get some tips from you regarding these topics. A very happy
> Easter for those of you who celebrate it!
>
> Thanks,
> Lucia Dossin
>
> --
> -------------------
> www.fiveblackcats.com
>
> KvK 34375444
>
> BR +55 11 3042.2923
> NL +31 (0) 6 2471.2500
> -------------------
>
>
>
> ------------------------------
>
> Message: 5
> Date: Sat, 7 Apr 2012 13:39:54 -0500
> From: Chip Bennett <chip at chipbennett.net>
> Subject: Re: [theme-reviewers] #7076 - My first review - some
> 	questions
> To: theme-reviewers at lists.wordpress.org
> Message-ID:
> 	<CAPdLKqfq-KecOwbV50_tnS2+5=N_b3qu6AsmmVndW+2eB=URsw at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> See comments inline:
>
> On Sat, Apr 7, 2012 at 12:32 PM, Lucia Dossin
> <lucia at fiveblackcats.com>wrote:
>
>> Hi there,
>> I just finished my first review (ticket #7076, Zenon Lite) and I'd like
>> to
>> check some points with you, the veterans, before I proceed ;) .
>>
>> Policy Requirements
>> ------------------
>> - must all icons/graphics have an explicit license or is a general info
>> about License in the readme.txt enough?
>>
>
> If the Theme developer owns copyright on all icons/graphics (and states
> such), then the general license is fine. Otherwise, Theme should indicate
> copyright/license for the bundled icons/graphics.
>
>
>> - theme has a folder called ie6 where there's a js file with messages
>> asking the user to upgrade their browser. There's no option to disable
>> that
>> in the Admin interface. Is that ok?
>>
>
> This is Plugin territory.
>
>
>> - theme has an about.php file, inside admin folder, where theme author
>> lists his facebook, twitter, flickr pages and his website as well. He
>> also
>> displays there a comparison table + link to the Pro version of this
>> Theme.
>> is that ok?
>>
>
> Yes, Upsell Themes are fine. Be sure to check the Guidelines regarding
> Upsell Themes, but at a glance, I can't find anything that would cause a
> problem. (e.g. both versions are GPL-licensed, and the commercial version
> doesn't lock core WP functionality behind the paywall).
>
>
>> -Theme comes with 3 font options. They are licenced under SIL Open Font
>> License (OFL), I guess that's ok, right?
>>
>
> Yes, SIL OpenFont is GPL-compatible. Refer to the Guidelines for the list
> of known-GPL-compatible font licenses.
>
>>
>>
>> Theme Check Results
>> ------------------
>> Theme passed the tests and the following result messages were displayed.
>> (1)RECOMMENDED: No reference to add_editor_style() was found in the
>> theme.
>> It is recommended that the theme implement editor styling, so as to make
>> the editor content match the resulting post output in the theme, for a
>> better user experience.
>> ->My question: should I mention that in the review?
>>
>>  (2)RECOMMENDED: No reference to add_custom_image_header was found in
>> the
>> theme. It is recommended that the theme implement this functionality if
>> using an image for the header.
>> ->My comment on that: No image for the header, so I guess it's ok.
>>
>> Three more INFO notices were displayed.
>>
>
> Do NOT list recommended or info results in the Theme Review, unless they
> are relevant - i.e. unless they are involved in a REQUIRED comment.
>
>>
>>
>> Theme Unit Tests
>> ----------------
>> - If one of the options provided by Theme is checked (Enable Sticky
>> Menu),
>> Blog title rotates 90 degrees as I scroll (Firefox 11). Seems to be a
>> bug.
>> This options is checked by default.
>>
>
> That is definitely an issue, unless it is somehow by design.
>
>
>>
>> - Post with no title links to error 404 page.
>>
>
> That is a known bug in core, regarding numeric-only post titles/slugs.
> Edit
> the post and reset the post slug, and that *should* resolve the problem.
>
>
>>
>> - Long menu doesn't 'break' the site layout but some menu items are
>> displayed out of the menu bar. No mention to menu items limit was found
>> in
>> the readme.txt.
>>
>
> This should also be noted.
>
>
>>
>> - Validation: theme did not pass markup validation, got 36 errors. The
>> first error refers to nested ul tags (they seem right, though).
>>
>
>
> Only comment regarding validation errors if they cause layout/markup
> breakage. (Note: be sure to test validation on a post such as "Readability
> Test", in order to minimize content-related validation errors.)
>
> Thanks for helping with Theme reviews!
>
> Chip
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/ef56bd80/attachment.htm>
>
> ------------------------------
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> End of theme-reviewers Digest, Vol 23, Issue 23
> ***********************************************
>