[theme-reviewers] stylesheet import vs enqueue

[Paul de Wouters]

Hi

In the theme review guide by Chip, it says stylesheets must be enqueued, so does that mean that if the main stylesheet is empty except for 3 @import declarations, the theme isn't valid?

---- On Wed, 19 Oct 2011 10:00:02 -0200  <theme-reviewers-request at lists.wordpress.org> wrote ---- 


Send theme-reviewers mailing list submissions to 
    theme-reviewers at lists.wordpress.org 
 
To subscribe or unsubscribe via the World Wide Web, visit 
    http://lists.wordpress.org/mailman/listinfo/theme-reviewers 
or, via email, send a message with subject or body 'help' to 
    theme-reviewers-request at lists.wordpress.org 
 
You can reach the person managing the list at 
    theme-reviewers-owner at lists.wordpress.org 
 
When replying, please edit your Subject line so it is more specific 
than "Re: Contents of theme-reviewers digest..." 
 
 
Today's Topics: 
 
 1. Re: [WordPress Themes] Custom Community, new version 1.8.7 (Otto) 
 2. Re: [WordPress Themes] Custom Community, new version 1.8.7 (Otto) 
 3. Re: [WordPress Themes] Custom Community, new version 1.8.7 
 (Chip Bennett) 
 
 
---------------------------------------------------------------------- 
 
Message: 1 
Date: Tue, 18 Oct 2011 14:53:41 -0500 
From: Otto <otto at ottodestruct.com> 
Subject: Re: [theme-reviewers] [WordPress Themes] Custom Community, 
    new version 1.8.7 
To: theme-reviewers at lists.wordpress.org 
Message-ID: 
    <CAD-FghxE8dhO5WfuLd+qKmKFnx3FnELjL-9jmH6XpC3RQRHUOA at mail.gmail.com> 
Content-Type: text/plain; charset=ISO-8859-1 
 
On Tue, Oct 18, 2011 at 2:51 PM, Chip Bennett <chip at chipbennett.net> wrote: 
> We "mark as old" Themes that are not-approved. They stay in the Extend queue 
> until we do so. 
 
Oh. 
 
The upload process automatically marks any previous pending versions 
of a theme as "old" when a new version gets uploaded, so assuming the 
theme author is going to fix the problems with the theme, the old 
version will disappear when they upload a new one. 
 
So unless you're picky about an orderly pending list, it's not 
actually necessary to take that step. 
 
-Otto 
 
 
------------------------------ 
 
Message: 2 
Date: Tue, 18 Oct 2011 14:56:12 -0500 
From: Otto <otto at ottodestruct.com> 
Subject: Re: [theme-reviewers] [WordPress Themes] Custom Community, 
    new version 1.8.7 
To: theme-reviewers at lists.wordpress.org 
Message-ID: 
    <CAD-Fghye8qQPDCiWK7sTv8no5d_LFY4O2qy2XhB7jLdR-VanDA at mail.gmail.com> 
Content-Type: text/plain; charset=ISO-8859-1 
 
On Tue, Oct 18, 2011 at 2:40 PM, Chip Bennett <chip at chipbennett.net> wrote: 
> If we went a route similar to this, I would propose that instead of using 
> PRIORITY, we update the Trac workflow to add an additional STATE, of 
> "review-complete" (or whatever is appropriate). 
> And if we go this route, I would suggest looking into adding a TRAINEE user 
> level, for which the only elevated permission is to change the ticket state 
> to "review-complete". 
> From purely a workflow standpoint, using the "needs-sync" priority is really 
> no improvement over using keywords (either way, the admin still has to 
> change the priority, just as the admin currently has to remove the sync 
> keyword). 
 
Agreed on the workflow, however that's a bit beyond what I have the 
capability to easily alter at present. I've emailed the sysadmins 
about a similar change, when they get back to me I'm going to try to 
get a copy of the existing ini file and set up a test trac. Then I can 
see about making some changes to the workflow. 
 
-Otto 
 
 
------------------------------ 
 
Message: 3 
Date: Tue, 18 Oct 2011 15:00:37 -0500 
From: Chip Bennett <chip at chipbennett.net> 
Subject: Re: [theme-reviewers] [WordPress Themes] Custom Community, 
    new version 1.8.7 
To: theme-reviewers at lists.wordpress.org 
Message-ID: 
    <CAPdLKqewFqFJo+mKoh-5f1FRnuV+e6CU06c+XZ3QMdVSyRVTvg at mail.gmail.com> 
Content-Type: text/plain; charset="iso-8859-1" 
 
The assumption that Theme developers re-submit their Themes with fixes is... 
not terribly valid, unfortunately. 
 
Also, having the Extend queue as clean as possible helps to find the Themes 
that need to be synchronized as *live*. 
 
And: you know me. I'm way past "picky"; I'm a pedant. 
 
Chip 
 
On Tue, Oct 18, 2011 at 2:53 PM, Otto <otto at ottodestruct.com> wrote: 
 
> On Tue, Oct 18, 2011 at 2:51 PM, Chip Bennett <chip at chipbennett.net> 
> wrote: 
> > We "mark as old" Themes that are not-approved. They stay in the Extend 
> queue 
> > until we do so. 
> 
> Oh. 
> 
> The upload process automatically marks any previous pending versions 
> of a theme as "old" when a new version gets uploaded, so assuming the 
> theme author is going to fix the problems with the theme, the old 
> version will disappear when they upload a new one. 
> 
> So unless you're picky about an orderly pending list, it's not 
> actually necessary to take that step. 
> 
> -Otto 
> _______________________________________________ 
> theme-reviewers mailing list 
> theme-reviewers at lists.wordpress.org 
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers 
> 
-------------- next part -------------- 
An HTML attachment was scrubbed... 
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20111018/c36c1f97/attachment-0001.htm> 
 
------------------------------ 
 
_______________________________________________ 
theme-reviewers mailing list 
theme-reviewers at lists.wordpress.org 
http://lists.wordpress.org/mailman/listinfo/theme-reviewers 
 
 
End of theme-reviewers Digest, Vol 17, Issue 60 
*********************************************** 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20111019/2c074003/attachment-0001.htm>