[theme-reviewers] theme_update_available

Sun Oct 9 03:45:11 UTC 2011

I apologize to interject here, however I am also seeing few potential issues
with current version. Upon Theme activation, Theme styles are being set
outside of your Theme Options, for example:

<link rel='stylesheet' id='anvil-admin-css-css' href='
http://example.com/wp-content/themes/wordsmith-anvil/functions/styles/admin.css?ver=1.0'
type='text/css' media='all' /> and in right away you will have few changes
to WordPress Core styles such as: http://cl.ly/2P3u1w0K1n2r2E0c2f1R

And also JS files are not enqued properly either:
<script type='text/javascript' src='
http://themeid.com/dev/wp-content/themes/wordsmith-anvil/functions/js/admin.js?ver=1.0
'></script>

Not sure if this is the main reason, however it is highly suggested to use
JS/CSS only where you actually need them and that's Theme Options. I also
see bunch of separated if ( !is_admin() ) { that is not necessary. To
simplify and to isolate your scripts see how this was done in Twenty Eleven
Theme: /inc/theme-options.php

/**
 * Properly enqueue styles and scripts for our theme options page.
 *
 * This function is attached to the admin_enqueue_scripts action hook.
 *
 * @since Twenty Eleven 1.0
 *
 */
function twentyeleven_admin_enqueue_scripts( $hook_suffix ) {
 wp_enqueue_style( 'twentyeleven-theme-options',
get_template_directory_uri() . '/inc/theme-options.css', false, '2011-04-28'
);
 wp_enqueue_script( 'twentyeleven-theme-options',
get_template_directory_uri() . '/inc/theme-options.js', array( 'farbtastic'
), '2011-06-10' );
 wp_enqueue_style( 'farbtastic' );
}
add_action( 'admin_print_styles-appearance_page_theme_options',
'twentyeleven_admin_enqueue_scripts' );

Even if this is not the answer to your problems you should alter
your enqueue in next release. There is no need to use any of them outside of
Theme Options period.

*Additional Info:*
In http://ajax.googleapis.com/ajax/libs/jquery/1.6.1/jquery.min.js?ver=3.2.1you
are not assigning proper version numbers as well, ver=3.2.1 should be
ver=1.6.1. somehow you're passing WordPress version into your scripts. This
will not break anything, but it does not look right :) After, false your can
add the actual version see above.

Cheers,
Emil

*----*
*Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
emil at themeid.com | http://themeid.com
Make everything as simple as possible, but not simpler. - Albert Einstein

On Sat, Oct 8, 2011 at 10:22 PM, Dion Hulse (dd32) <wordpress at dd32.id.au>wrote:

> No, not at all, was just giving you a heads up on a potential issue for
> future theme releases!
>
>
> On 9 October 2011 14:16, Tom Matteson <perspectivevision at gmail.com> wrote:
>
>> Dion ...
>>
>> Are you saying that enqueuing the admin css and js could be causing this?
>>
>> *Best Regards
>>  Tom Matteson*
>>
>>
>>
>>
>> On Sat, Oct 8, 2011 at 7:08 PM, Dion Hulse (dd32) <wordpress at dd32.id.au>wrote:
>>
>>> It doesn't do any user tracking, nor does it care about where you're
>>> running.
>>>
>>> Try changing the version string on one of those sites to a older version,
>>> and reloading the themes page, see if it picks it up then?
>>>
>>> The other thing that comes to mind, is if all the servers you're testing
>>> on are on a slower network, the update checks might be timing out, so it's
>>> only the once-ever-24hrs check that waits longer for a response that's
>>> working, and so not picking up the updates..
>>>
>>> Assuming everything else is working, there's not much else that can be
>>> impacting upon it (except maybe a plugin..). If you've got a test install
>>> you don't mind letting me run a few debug items on, I can give you an exact
>>> reason why the alert isn't showing for you. (contact me off-list)
>>>
>>> FYI, I'm getting this warning on 3.3:
>>> ( ! ) Notice: wp_enqueue_script was called incorrectly. Scripts and
>>> styles should not be registered or enqueued until the wp_enqueue_scripts,
>>> admin_enqueue_scripts, or init hooks. (This message was added in version
>>> 3.3.) in .... ..\anvil-options.php Lines 37 and 38
>>>
>>> On 9 October 2011 12:57, Tom Matteson <perspectivevision at gmail.com>wrote:
>>>
>>>> Caroline &  Dion ...
>>>>
>>>> Thanks for the quick feedback. However, I thought of this. Actually, to
>>>> test this before posting on the list, I tried installing older versions of
>>>> the theme on a couple different sites; including a site that is not
>>>> registered to me. The update message still didnt appear.  I wonder if
>>>> WordPress recognizes my IP address, or the email associated or domain
>>>> associated with my user login; and that is why it does not appear for me.
>>>> Any other thoughts on this. Dion, thx also for testing this. Glad it is
>>>> working on your computer, anyway.
>>>>
>>>> *Best Regards
>>>> Tom Matteson*
>>>>
>>>>
>>>>
>>>>
>>>> On Sat, Oct 8, 2011 at 6:23 PM, Dion Hulse (dd32) <wordpress at dd32.id.au
>>>> > wrote:
>>>>
>>>>> Hi Tom,
>>>>> I've just tested out your theme and the update API seems to be working
>>>>> correctly for it for me.
>>>>> (I installed the latest 2.1.1 version, changed the version in the
>>>>> style.css to 2.1.0 and reloaded the themes page, and got a notice for it)
>>>>>
>>>>> The main reason I can think of why you're not getting the alerts, would
>>>>> simply be due to your version number always matching the latest release or
>>>>> being up to date already? You'll never see the notice if you've already
>>>>> updated the theme on the site for testing before the theme was
>>>>> approved/published on WordPress.org.
>>>>>
>>>>> D
>>>>>
>>>>> On 9 October 2011 12:14, Tom Matteson <perspectivevision at gmail.com>wrote:
>>>>>
>>>>>> Greetings ...
>>>>>>
>>>>>> I have a theme on the Repository that has been updated a half-dozen
>>>>>> times or so. My understanding is that WordPress.org runs a cron job twice a
>>>>>> day that checks all the self installed WordPress installations to query
>>>>>> which themes, plugins etc are installed. From what I have read the
>>>>>> theme_update_available function in theme.php is supposed to display '
>>>>>> *There is a new version of %1$s <http://../../_variables/s.html>available'
>>>>>> * *with an update url*, whenever there is a new version of the theme,
>>>>>> if it detects a there is a newer version of any of the installed themes that
>>>>>> reside in the Repository. Unless I am misunderstanding something, this is
>>>>>> the default behavior, unless the theme has added some code to bypass the
>>>>>> this function.
>>>>>>
>>>>>> I have not added any functions to bypass the theme_update_available().
>>>>>> However, even though I see the update message displayed for other themes, I
>>>>>> have never seen it displayed for my theme, Wordsmith-Anvil. Does anyone know
>>>>>> what would cause this function not to work for my theme?
>>>>>>
>>>>>> *Best Regards
>>>>>> Tom Matteson*
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20111008/1ba2439a/attachment.htm>