[theme-reviewers] Questions about ticket no. 2811

[Chip Bennett]

WordPress does include a default comments template, but note what it says:

// Backward compat code will be removed in a future release
require( ABSPATH . WPINC . '/theme-compat/comments.php');


This is old code, and left only for backwards compatibility. It is
deprecated, and expressly disallowed for Repository-hosted Themes.

You're getting PHP errors for the $text_domain variable, because you do not
define this variable at all, much less, define it before using it.

You're getting PHP errors for undefined $user_url, apparently because there
is no user_url defined for $wp_query->get_queried_object().

The rest are similar, and unrelated to the above errors.

Note that the Codex isn't necessarily a repository of "cut-and-paste" code.
Generally, it has *example* code, that you must modify to suit your specific
code.

Chip

On Tue, May 24, 2011 at 12:32 PM, Angelo Bertolli <angelo.bertolli at gmail.com
> wrote:

> Hi everyone, I am asking questions here because I haven't gotten any
> response on my ticket and it is mentioned in the ticket to ask on the
> theme reviewer's list.
>
> (1) So my first question isn't a problem but... why are we required to
> include a comments.php file?  I removed my comments.php file for
> simplicity after I learned that WordPress automatically inserts the
> comment code when there isn't one.  It seemed better to default to WP's
> default functionality.  But when I tried to upload, it was automatically
> rejected.
>
>
> (2) I'm in some general confusion about the other errors...
> => Undefined variable: text_domain in \themes\dragonskin\functions.php
> on line 11
> => Undefined variable: text_domain in \themes\dragonskin\functions.php
> on line 12
>
> This code is straight from the WordPress documentation on:
> http://codex.wordpress.org/Function_Reference/dynamic_sidebar
>
> => Undefined property: stdClass::$user_url in
> \themes\dragonskin\single.php on line 34
>
> It is defined here (and works):
> http://codex.wordpress.org/Author_Templates#Custom_Author_Information
>
> The rest seem like errors generated resultant from previous issues.
>
> => Undefined index: action in \themes\dragonskin\functions.php on line 97
> => Undefined index: action in \themes\dragonskin\functions.php on line 108
> => Undefined index: saved in \themes\dragonskin\functions.php on line 127
> => Undefined index: reset in \themes\dragonskin\functions.php on line 128
>
> => Undefined index: sidebar-1 in
> C:\xampp\htdocs\wp\wp-includes\widgets.php on line 954
> => Undefined index: top-menu in
> C:\xampp\htdocs\wp\wp-includes\widgets.php on line 954
>
> But I followed the directions on the WordPress Codex, I believe.  Also,
> it is an unclear error that is generated from WP's widgets.php file and
> therefore harder for me to understand what the problem is.
>
>
>
> Please tell me what you think is going on here, or what I should try to
> do next.  My plan is to use the theme development plugin to see if I
> can't figure this out, but it's very hard for me if some stuff in the
> Codex is missing.  I mean... is this a case where the Codex isn't up to
> date?
>
>
> Angelo
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110524/e10c1eee/attachment.htm>