[theme-reviewers] $post->guid Issues in Some Repository Themes

[Edward Caissie]

OK, thanks for the info @Mike and @Otto ... I can accept it as a "doing it
wrong" item, but the question for the Team now becomes how do we wade
through all of the themes the search criteria finds aside from installing
and "Theme Check"-ing them after the new test is implemented?

I'm not seeing this as a security issue (requiring immediate action), just
simply "doing-it-wrong" scenarios where something might break. The use of
$post-guid appears to be spread out amongst many different authors, too.
Although this is being considered a "doing it wrong" item, can we
grand-father the existing live themes in the repository and clamp down on
new themes and submissions? I noticed some rather "popular" themes in the
search results that I would rather not suspend as our first choice of
action.

The Theme authors may not be using 'guid' *correctly*, but their themes
appear to be functioning correctly all the same.


Cais.

On Thu, Jun 23, 2011 at 5:23 PM, Otto <otto at ottodestruct.com> wrote:

> On Thu, Jun 23, 2011 at 4:14 PM, Chip Bennett <chip at chipbennett.net>
> wrote:
> > Is there a logical way to flag inappropriate use, while ignoring
> appropriate
> > use?
>
> I thought something like this might work:
>
> If the theme uses the_guid() or get_the_guid() or $post->guid
> anywhere, and it also doesn't include the use of the add_feed()
> function anywhere else in the theme, then it's doing-it-wrong.
>
> add_feed would be the correct way to add feeds, and the only place
> using the guid makes sense is in a feed.
>
> -Otto
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110623/b44c9c54/attachment.htm>