[theme-reviewers] $post->guid Issues in Some Repository Themes

[Otto]

On Thu, Jun 23, 2011 at 3:16 PM, Mike Little <wordpress at zed1.com> wrote:
> On Thu, Jun 23, 2011 at 20:53, Simon Prosser <pross at pross.org.uk> wrote:
>> I got a tweet from Chip asking for theme-check to flag it as bad, so ..
>> Are people not supposed to use it at all? if so theme fails? and if so
>> what is the suggested alternative?
>
> You should *never*, *ever* use the guid in your theme.

... unless you're using it for the right thing.

Concept: Photoblog theme. Creates a special media-enabled rss feed for
photo posts only. Uses the guid in the feed.

Concept: Podcasting specific theme. Ditto for podcast enabled feed.
Uses guid in the feed properly.

Never use the GUID field as a "permalink", because it's not one.

If we add this to the theme check, it should be a strong warning, not
a requirement to pass the upload. Too many possible specialized cases
that I'd rather not exclude outright.

-Otto