[theme-reviewers] Theme Check and Text Domains

[Simon Prosser]

OK well we'll give it a few days for you guys to test, and see if Otto has
anything to add to this revision before bumping the version.

On 27 July 2011 09:00, Vicky Arulsingam <vicky.arulsingam at gmail.com> wrote:

> It's working now. I tried it on another computer.
>
> Vicky
>
>
> On Wed, Jul 27, 2011 at 1:25 AM, Simon Prosser <pross at pross.org.uk> wrote:
>
>> sure?
>> gives me this:
>>
>>
>>    - RECOMMENDED: Text domain problems in *single.php*. The twentyten
>>    text domain is being used!
>>
>>
>>    Line 12: <div class='nav-next'><?php next_post_link( '%link', '%title <span class='meta-nav'>' . _x( '&rarr;', 'Next post link', 'twentyten' ) . '</span>' ); ?></div>
>>
>>    - RECOMMENDED: Text domain problems in *single.php*. The twentyten
>>    text domain is being used!
>>
>>
>>    Line 11: <div class='nav-previous'><?php previous_post_link( '%link', '<span class='meta-nav'>' . _x( '&larr;', 'Previous post link', 'twentyten' ) . '</span> %title' ); ?><
>>
>>    - RECOMMENDED: Text domain problems in *admin/nrg-options.php*. You
>>    have not included a text domain!
>>
>>
>>    Line 28: add_theme_page( __( $themename.' Energy Options' ), __( 'Energy Options' ), 'edit_theme_options', basename(__FILE__), 'energy_s
>>
>>    - RECOMMENDED: *Author URI:* is missing from your style.css header.
>>    - INFO: *js/ie-pie/PIE.php* The theme appears to use include or
>>    require. If these are being used to include separate sections of a template
>>    from independent files, then *get_template_part()* should be used
>>    instead.
>>
>>
>>    Line 18: include( 'PIE.htc' );
>>
>>
>>
>> On 26 July 2011 18:10, Vicky Arulsingam <vicky.arulsingam at gmail.com>wrote:
>>
>>> Hmmm, The dev version didn't work. It's not throwing any warnings.
>>>
>>> Vicky
>>>
>>>
>>> On Wed, Jul 27, 2011 at 12:18 AM, Simon Prosser <pross at pross.org.uk>wrote:
>>>
>>>> Thx Vicky!
>>>>
>>>> New regex added to catch _x
>>>>
>>>> Please try dev version.
>>>> http://downloads.wordpress.org/plugin/theme-check.zip
>>>>
>>>> On 26 July 2011 16:20, Vicky Arulsingam <vicky.arulsingam at gmail.com>wrote:
>>>>
>>>>>
>>>>> Theme Check didn't return a notice for the use of the 'twentyten' text
>>>>> domain in the Energy theme:
>>>>> http://themes.svn.wordpress.org/energy/1.04/single.php
>>>>>
>>>>> I guess it's because the theme author is using "_x()" rather than
>>>>> "__()" or "_e()"
>>>>>
>>>>> -----
>>>>> Vicky Arulsingam
>>>>>
>>>>>
>>>>>
>>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> --
>> My Blog: http://www.pross.org.uk/
>> Plugins : http://www.pross.org.uk/plugins/
>> Themes: http://wordpress.org/extend/themes/profile/pross
>>
>>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


-- 
My Blog: http://www.pross.org.uk/
Plugins : http://www.pross.org.uk/plugins/
Themes: http://wordpress.org/extend/themes/profile/pross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110727/6fcdff08/attachment.htm>