[theme-reviewers] Theme Unit Test Data: Gallery Columns

[Chip Bennett]

I use 10 personally, just because it's a nice, round number. And I'm an
engineer, so I naturally think in orders of magnitude. :)

At least for the time being (given the nature of the core implementation),
I'm fine with allowing Themes to support the default number of columns, and
if necessary to document the limitation in the Theme documentation.

Getting a fix in core is probably a minimum workaround. However, I still
would much rather see us get to the point where core isn't adding in
arbitrary styling for one arbitrary component (galleries), when *core
doesn't define markup for absolutely anything else* on the front end.

The excuse I got in the ticket was that making the change (to remove the
inline styles added for the gallery shortcode) would "break" existing
Themes. I'd rather see that battle fought and won, but if not, then the next
alternative would be to add in core styling for up to 9 columns.

Chip

On Sat, Jul 16, 2011 at 3:59 PM, Michael Fields <michael at mfields.org> wrote:

>
> > I had actually forgotten about that dropdown in the Media/Gallery modal
> window. That is actually a rather compelling argument for Twenty Eleven, at
> the very least, to support up to 9 columns.
>
> I kinda thought so :) I always wondered where you got the number 10 from
> ...
>
> > The problem I see with allowing Themes to specify the number of columns
> supported, in a way that impacts that dropdown, is that it would cause
> unexpected behavior for pre-existing galleries that might have specified
> more columns than the number for which the Theme indicates support.
>
> Great point! Thing is that unexpected behavior occurs when the theme does
> not support the columns defined as well. Perhaps the best route would be to
> work out css that would be generated by core and added to the styles already
> printed. This could take the burden completely off of the theme author while
> respecting the users wishes.
>
> On Jul 16, 2011, at 1:41 PM, Chip Bennett wrote:
>
> > I had actually forgotten about that dropdown in the Media/Gallery modal
> window. That is actually a rather compelling argument for Twenty Eleven, at
> the very least, to support up to 9 columns.
> >
> > The problem I see with allowing Themes to specify the number of columns
> supported, in a way that impacts that dropdown, is that it would cause
> unexpected behavior for pre-existing galleries that might have specified
> more columns than the number for which the Theme indicates support.
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110716/5f9b920e/attachment.htm>