[theme-reviewers] Theme Unit Test Data: Gallery Columns

Sat Jul 16 20:41:40 UTC 2011

I definitely think that there is a place for galleries with more than 4
columns. For galleries of more than a couple dozen photos, the horizontal
space required for the gallery becomes excessive, unless the number of
columns is increased (even at the expense of creating smaller thumbnails).

I had actually forgotten about that dropdown in the Media/Gallery modal
window. That is actually a rather compelling argument for Twenty Eleven, at
the very least, to support up to 9 columns.

The problem I see with allowing Themes to specify the number of columns
supported, in a way that impacts that dropdown, is that it would cause
unexpected behavior for pre-existing galleries that might have specified
more columns than the number for which the Theme indicates support.

Chip

On Sat, Jul 16, 2011 at 11:56 AM, Michael Fields <michael at mfields.org>wrote:

> Just a few thoughts on this topic:
>
> Themes can style all of the gallery columns without modifying the inline
> css printed by the gallery shortcode.
> It can even be done without use of !important if the right specificity is
> used.
> Please see the following patch for twentyeleven.
>
> http://core.trac.wordpress.org/ticket/17564
>
> The related ticket is here:
>
> http://core.trac.wordpress.org/ticket/17564
>
> If you read the ticket, you'll see that I originally supplied a patch that
> supported 9 columns, but only 4 columns ended up being supported by the
> theme. Ian Stewart commented that supporting anything over 4 columns "seems
> a bit much". This is one of those situations where I agree and disagree at
> the same time. I mean, a 9-column gallery is something that I would never
> use in practice. Most themes do not even have room to do it well.
>
> Here's an example from my own theme:
> http://wordpress.mfields.org/test/gallery-shortcode/ the thumbnails are
> tiny compared to the actual size of the image. The only galleries that
> display the correct image size are the ones having 1 - 4 columns. In
> galleries showing 5 - 9 columns, the images are resized in the browser to
> enable then to fit inside the theme.
>
> One possible solution that I see here is to all theme author the ability to
> define theme support for "gallery_columns". WordPress can then use this
> value to modify the number of options displayed in the "Gallery Settings"
> section of the modal media window.
>
> Best,
> -Mike
>
>
>
> On Jul 16, 2011, at 9:30 AM, Merci Javier wrote:
>
> >
> > At this point, what's the bottom line for required minimum number of
> columns supported by a theme if they override the WP gallery styles as
> opposed to recommended (10 columns) when reviewing a theme? 3, 4, or 5
> columns?
> >
> >
> >
> > On Sat, Jul 16, 2011 at 8:43 AM, Chip Bennett <chip at chipbennett.net>
> wrote:
> > I'll link the existing ticket when I'm back at my laptop; it's been
> wontfixed.
> >
> > Chip
> >
> > On 7/16/11, Edward Caissie <edward.caissie at gmail.com> wrote:
> > > I'm reading "needs patch" from this discussion to "correct" the method
> core
> > > is currently using.
> > >
> > > As a recommendation, I'm all for it ... if we can have core "fixed" to
> a
> > > more "correct" method or default style then I would entertain the
> > > possibility of pushing the recommendation to a requirement as we have
> done
> > > with other guidelines.
> > >
> > >
> > > Cais.
> > >
> > >
> > > On Fri, Jul 15, 2011 at 7:56 PM, Chip Bennett <chip at chipbennett.net>
> wrote:
> > >
> > >> +1 to this:
> > >>
> > >> *With that said, WP's handling of this is crap.*
> > >>
> > >>
> > >> And therein lies the problem with even considering making it a
> > >> requirement.
> > >> The underlying implementation (inline styles by default, and force
> Theme
> > >> developers to remove them via filter) impedes Theme developers - but
> I've
> > >> tried to fight that fight, and lost. So, as long as WordPress core
> > >> continues
> > >> NOT to do it right, I think it would be an unreasonable burden on
> Theme
> > >> developers to *require* them to support more than the default number
> of
> > >> columns.
> > >>
> > >> Chip
> > >>
> > >>
> > >> On Sat, Jul 16, 2011 at 6:33 PM, Justin Tadlock
> > >> <justin at justintadlock.com>wrote:
> > >>
> > >>> Part of me thinks it should be a requirement.  WordPress already
> handles
> > >>> styles for 1 - 10 columns (and more) by default.  If a theme is
> > >>> overwriting
> > >>> this with custom styles or removing the inline <style> WP adds, they
> need
> > >>> to
> > >>> handle this on their own.  That's where the biggest problem is --
> themes
> > >>> overwriting this but not handling anything other than 3 columns.
> > >>>
> > >>> With that said, WP's handling of this is crap.  I've never designed a
> > >>> theme where it doesn't break with the default WP styles.  Of course,
> I
> > >>> always roll my own handling of this anyway.
> > >>>
> > >>>
> > >>> On 7/15/2011 5:39 PM, Ian Stewart wrote:
> > >>>
> > >>>> On 2011-07-15, at 5:36 PM, Chip Bennett wrote:
> > >>>>
> > >>>>  Personally, I wasn't even thinking along those lines. Making
> something
> > >>>>> like that a *requirement* seems, IMHO, to cross the line into
> dictating
> > >>>>> design intent.
> > >>>>>
> > >>>>> The idea of adding it as a *recommendation* would merely be to
> raise
> > >>>>> awareness of an area that Theme developers may not previously have
> > >>>>> considered styling.
> > >>>>>
> > >>>> Sounds good to me.
> > >>>>
> > >>>> Ian Stewart
> > >>>>
> > >>>> ______________________________**_________________
> > >>>> theme-reviewers mailing list
> > >>>> theme-reviewers at lists.**wordpress.org<
> theme-reviewers at lists.wordpress.org>
> > >>>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
> > >>>>
> > >>>>
> > >>>>  ______________________________**_________________
> > >>> theme-reviewers mailing list
> > >>> theme-reviewers at lists.**wordpress.org<
> theme-reviewers at lists.wordpress.org>
> > >>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
> > >>>
> > >>
> > >>
> > >> _______________________________________________
> > >> theme-reviewers mailing list
> > >> theme-reviewers at lists.wordpress.org
> > >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> > >>
> > >>
> > >
> >
> > --
> > Sent from my mobile device
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110716/939312c1/attachment-0001.htm>