[theme-reviewers] Theme Unit Test Data: Gallery Columns

[Edward Caissie]

I'm reading "needs patch" from this discussion to "correct" the method core
is currently using.

As a recommendation, I'm all for it ... if we can have core "fixed" to a
more "correct" method or default style then I would entertain the
possibility of pushing the recommendation to a requirement as we have done
with other guidelines.


Cais.


On Fri, Jul 15, 2011 at 7:56 PM, Chip Bennett <chip at chipbennett.net> wrote:

> +1 to this:
>
> *With that said, WP's handling of this is crap.*
>
>
> And therein lies the problem with even considering making it a requirement.
> The underlying implementation (inline styles by default, and force Theme
> developers to remove them via filter) impedes Theme developers - but I've
> tried to fight that fight, and lost. So, as long as WordPress core continues
> NOT to do it right, I think it would be an unreasonable burden on Theme
> developers to *require* them to support more than the default number of
> columns.
>
> Chip
>
>
> On Sat, Jul 16, 2011 at 6:33 PM, Justin Tadlock <justin at justintadlock.com>wrote:
>
>> Part of me thinks it should be a requirement.  WordPress already handles
>> styles for 1 - 10 columns (and more) by default.  If a theme is overwriting
>> this with custom styles or removing the inline <style> WP adds, they need to
>> handle this on their own.  That's where the biggest problem is -- themes
>> overwriting this but not handling anything other than 3 columns.
>>
>> With that said, WP's handling of this is crap.  I've never designed a
>> theme where it doesn't break with the default WP styles.  Of course, I
>> always roll my own handling of this anyway.
>>
>>
>> On 7/15/2011 5:39 PM, Ian Stewart wrote:
>>
>>> On 2011-07-15, at 5:36 PM, Chip Bennett wrote:
>>>
>>>  Personally, I wasn't even thinking along those lines. Making something
>>>> like that a *requirement* seems, IMHO, to cross the line into dictating
>>>> design intent.
>>>>
>>>> The idea of adding it as a *recommendation* would merely be to raise
>>>> awareness of an area that Theme developers may not previously have
>>>> considered styling.
>>>>
>>> Sounds good to me.
>>>
>>> Ian Stewart
>>>
>>> ______________________________**_________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>
>>>
>>>  ______________________________**_________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110716/05a44b8e/attachment.htm>