[theme-reviewers] Theme Check: enqueuing 'comment-reply' as a dependency fails the theme

[Simon Prosser]

regex's do have limitations especially when things are broken onto
multiple lines.

On 13 July 2011 19:23, Chip Bennett <chip at chipbennett.net> wrote:
> I can't see anything wrong with the method being employed here. P2 is doing
> nothing other than building a dependency array, causing WP to enqueue all
> scripts in the array, using core-defined functionality.
> This isn't concatenation in the same connotation as previously discussed. No
> files are being modified. Only core files are being used. No versions are
> being changed from core-bundled versions.
> I can't see any other issues with this implementation, other than that Theme
> Check wasn't sophisticated enough to look for it.
> Chip
>
> On Wed, Jul 13, 2011 at 11:36 AM, Sayontan Sinha <sayontan at gmail.com> wrote:
>>
>> Is this allowed? I thought themes weren't supposed to do things like JS
>> concatenation and that this was strictly plugin territory.
>>
>> On Tue, Jul 12, 2011 at 8:54 PM, Lance Willett <nanobar at gmail.com> wrote:
>>>
>>> > Lance, why is there a bash file? in bin/?
>>>
>>> It's for concatenating JS files into one JS file, for WP.org users
>>> that want to save HTTP requests.
>>>
>>> – Lance
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>>
>> --
>> Sayontan Sinha
>> http://mynethome.net | http://mynethome.net/blog
>> --
>> Beating Australia in Cricket is like killing a celebrity. The death gets
>> more coverage than the crime.
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>



-- 
My Blog: http://www.pross.org.uk/
Plugins : http://www.pross.org.uk/plugins/
Themes: http://wordpress.org/extend/themes/profile/pross