[theme-reviewers] Heavily Commented Javascript Files.

[Chip Bennett]

...which is a bit different from what Michael was originally proposing:

"The live version would contain the same functional code minus excess
whitespace and comments. I would not use any compression or package
application to obfuscate the code."


I think condensing/minifying is different from compressing. The former I
would see as not even a question; the latter, of course, would be an
entirely different matter. Fortunately, as far as I'm aware, nobody's tried
to submit anything with compressed/obfuscated code.

I'm with you, in that I would favor not allowing obfuscated code, even with
a "dev" version against which to compare it.

Chip

On Tue, Jul 5, 2011 at 6:32 AM, Otto <otto at ottodestruct.com> wrote:

> Ideally, I wouldn't want compressed scripts in there at all, unless
> they are open source scripts that come in a compressed version to
> begin with.
>
> If they have a dev.js and a compressed .js script, like the core does,
> then there should be some form of instructions as to how to compress
> the script, and the results should match. For the sake of preventing
> malware, if a theme reviewer is going to allow compressed scripts at
> all, then yeah, they should verify that the compression method
> produces the same results.
>
> -Otto
>
>
>
> On Mon, Jul 4, 2011 at 10:45 PM, Vicky Arulsingam
> <vicky.arulsingam at gmail.com> wrote:
> >
> > On Tue, Jul 5, 2011 at 11:42 AM, Otto <otto at ottodestruct.com> wrote:
> >>
> >> BTW, it would be nice if you specified how you were going to compress
> >> it in the comments or something. We don't want a case where somebody
> >> compresses something with malware in it, and then nobody notices. Your
> >> results should be reproducible.
> >>
> >> -Otto
> >>
> >
> > Should theme reviewers compress the dev script and see if it matches the
> > compressed version?
> >
> > -----
> > Vicky Arulsingam
> >
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
> >
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110705/b3290150/attachment.htm>