[theme-reviewers] Theme-Check plugin and textdomain

[Syahir Hakim]

Erm...so does the theme-check plugin searches for occurrences of the 
'twentyten' string, regardless of its context? Clearly in this case my 
theme is not using the twentyten textdomain.

Regarding the theme switch, I suppose that if WP doesn't find the 
twentyten theme, it'll display a message that goes something like this: 
"Theme is broken, reverting to default...".

In the Graphene theme, I used switch_theme('default', 'default'), which 
caused WP to always output the message above whenever I uninstall a 
theme, cause obviously there's no theme named 'default'. I guess before 
we have a theme uninstall hook, this is the best way to go. Or is there 
any suggestions?

-- 
Regards,
Syahir Hakim

Contact:
http://www.khairul-syahir.com
+6014 753 1883


On 19/1/2011 11:39 PM, Simon Prosser wrote:
> On 01/19/11 15:31, Syahir Hakim wrote:
>> I used Dreamweaver's search function, and there's no occurrence of
>> 'twentyten' inside __() or _e().
>>
>> Correcting my previous email, there's actually two occurrences of the
>> string 'twentyten', which is inside the theme's uninstall script, which
>> switches to the twentyten theme after deleting my theme's database entries.
>>
>> This is the line:
>> switch_theme('twentyten', 'twentyten');
>>
>> If I comment out that line, theme-check does not show any warning and
>> show that the theme passes the check. Uncomment that line, and the
>> warning appears.
> Thats what its designed to do ;)
>
> So you switch back to twentyten when a use uninstalles your theme?
> assuming of course the user HAS TwentyTen still installed, what if he
> does not?
>