[theme-reviewers] Theme-Check plugin and textdomain

Chip Bennett chip at chipbennett.net
Wed Jan 19 15:47:54 UTC 2011


Is this action even necessary?

A Theme can't be uninstalled through the Admin UI unless it is deactivated.
If it's already deactivated, then the user has already selected another
active Theme (or WordPress has already reverted - or attempted to revert -
to the default Theme).

Or am I missing something?

Chip

On Wed, Jan 19, 2011 at 9:39 AM, Simon Prosser <pross at pross.org.uk> wrote:

> On 01/19/11 15:31, Syahir Hakim wrote:
> > I used Dreamweaver's search function, and there's no occurrence of
> > 'twentyten' inside __() or _e().
> >
> > Correcting my previous email, there's actually two occurrences of the
> > string 'twentyten', which is inside the theme's uninstall script, which
> > switches to the twentyten theme after deleting my theme's database
> entries.
> >
> > This is the line:
> > switch_theme('twentyten', 'twentyten');
> >
> > If I comment out that line, theme-check does not show any warning and
> > show that the theme passes the check. Uncomment that line, and the
> > warning appears.
> Thats what its designed to do ;)
>
> So you switch back to twentyten when a use uninstalles your theme?
> assuming of course the user HAS TwentyTen still installed, what if he
> does not?
>
> --
> My Blog: http://www.pross.org.uk/
> Plugins: http://www.pross.org.uk/plugins/
> Themes : http://wordpress.org/extend/themes/profile/pross
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110119/f8ca2b11/attachment.htm>


More information about the theme-reviewers mailing list