[theme-reviewers] Theme-Check plugin and textdomain

[Daniel Tara]

WordPress should definitely have a hook for theme uninstall...

-----Original Message-----
From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Syahir
Hakim
Sent: Wednesday, January 19, 2011 5:32 PM
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] Theme-Check plugin and textdomain

I used Dreamweaver's search function, and there's no occurrence of
'twentyten' inside __() or _e().

Correcting my previous email, there's actually two occurrences of the string
'twentyten', which is inside the theme's uninstall script, which switches to
the twentyten theme after deleting my theme's database entries.

This is the line:
switch_theme('twentyten', 'twentyten');

If I comment out that line, theme-check does not show any warning and show
that the theme passes the check. Uncomment that line, and the warning
appears.

--
Regards,
Syahir Hakim

Contact:
http://www.khairul-syahir.com
+6014 753 1883


On 19/1/2011 11:26 PM, Chip Bennett wrote:
> In one of your template files, you are echoing content, using either
> __() or _e(), with 'twentyten' as the text domain.
>
> Check for default content, e.g. in sidebar.php, that is sometimes 
> easily overlooked.
>
> Chip
>
> On Wed, Jan 19, 2011 at 9:23 AM, Syahir Hakim <khairulsyahir at gmail.com 
> <mailto:khairulsyahir at gmail.com>> wrote:
>
>     Hi everyone,
>
>     I'm running the theme-check plugin against my new theme, and it
>     turns out this warning: *WARNING: Theme is using twentyten as the
>     textdomain!*
>
>     I've did a search on the theme's files, and not a single
>     occurrence of 'twentyten' is found. Anybody know why this warning
>     should appear?
>
>     -- 
>     Regards,
>     Syahir Hakim
>
>     Contact:
>     http://www.khairul-syahir.com
>     +6014 753 1883
>
>     _______________________________________________
>     theme-reviewers mailing list
>     theme-reviewers at lists.wordpress.org
>     <mailto:theme-reviewers at lists.wordpress.org>
>     http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers