[theme-reviewers] Unfair Feedback

[Chip Bennett]

The issue isn't that Post Thumbnails aren't incorporated; rather, it's all
the additional functionality in
rt-common.php<http://themes.svn.wordpress.org/isaac/0.1/php/rt-common.php>
that
can be accomplished *using* Post Thumbnails functionality for image
resizing.

What's being done here is roughly equivalent to backwards-compatibility for
TimThumb? <http://themes.trac.wordpress.org/wiki/TimThumb>, which isn't
currently being allowed.

Chip
On Sat, Jan 15, 2011 at 12:36 AM, Philip M. Hofer (Frumph) <
philip at frumph.net> wrote:

>  I do indeed see that post thumbnail functionality is here:
>
> $image = get_the_post_thumbnail( $post->ID, 'medium', array('class' => $thumb.' post-thumb') );
>
> in rt-post-summaries.php  and in rt-init.php
>
> add_theme_support( 'post-thumbnails' );
>
> I will make the necessary adjustment to the ticket after I myself have
> checked it out.
>
> - Phil
>
>
>
> ----- Original Message -----
> *From:* Rahul Bansal <rahul286 at gmail.com>
> *To:* theme-reviewers <theme-reviewers at lists.wordpress.org>
> *Sent:* Friday, January 14, 2011 10:31 PM
> *Subject:* [theme-reviewers] Unfair Feedback
>
>   Hi All,
>
> This is regarding rejection of my theme for reason cited here
> http://themes.trac.wordpress.org/ticket/2452#comment:3
>
> It states:
>
> > Theme must use Post Thumbnails feature for image-thumbnail and
> image-resize handling.
>
> First thing our theme uses "Post Thumbnails feature" for sure.
>
> Our theme adds thumbnail-support using wordpress core function and if
> featured-image has been uploaded, it gets displayed using "Post Thumbnails
> feature".
> But for old posts, which has no-featured images OR only contains
> external-image "Post Thumbnails feature" do not generate thumbnail.
> So we added if-else conditional block and when a post do not have
> featured-image or contains only external image, in "else" block we use
> regular expression to parse post-content for img tag and grap src path from
> that. Then we cache that image locally and generate thumbnails using
> timthumb library.
>
> We took extra efforts to automate things and maintain
> backward compatibility so a use need not edit old posts individually and had
> to set featured images on each of them.
>
> May I know why this is unacceptable on wordpress.org theme repo?
>
> Thanks,
>   -Rahul
> --
> Rahul Bansal | Founder & CEO | rtCamp Solutions Pvt. Ltd.
> Mobile: +91-9860501882 | Web: http://rtcamp.com/
>
> ------------------------------
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110115/ccf92cf0/attachment.htm>