[theme-reviewers] [WordPress Themes] #2407: THEME: Shadow -1.1.2
Philip M. Hofer (Frumph)
philip at frumph.net
Fri Jan 14 06:28:56 UTC 2011
Yes, all warnings and required need to be fixed or it will not pass again.
We would like you to think of recommended as "something you "should"" do,
but recommended's will not stop your theme from passing.
So fix the warnings and requireds, use the theme-check and other plugins to
test your code first on your dev site and upload again when you feel it will
pass.
- phil
----- Original Message -----
From: "Rashed Latif" <rashed.latif at gmail.com>
To: <theme-reviewers at lists.wordpress.org>
Sent: Thursday, January 13, 2011 10:24 PM
Subject: Re: [theme-reviewers] [WordPress Themes] #2407: THEME:
Shadow -1.1.2
> Thanks for reviewing my theme. Its not approved and i have gone
> through the report.
> I am just wondering should i only care about the "WARNINGS" and
> "REQUIRED" items generated from theme check script?
>
> What will be the next step for me before submitting this theme for
> reviewing again.
>
> I an new so help me please.
>
>
> On 1/14/11, WordPress Themes <theme-reviewers at lists.wordpress.org> wrote:
>> #2407: THEME: Shadow - 1.1.2
>> ---------------------------+--------------------------
>> Reporter: rashed.latif | Owner: greenshady
>> Type: theme | Status: closed
>> Resolution: not-approved | Keywords: theme-shadow,
>> ---------------------------+--------------------------
>> Changes (by greenshady):
>>
>> * status: accepted => closed
>> * resolution: => not-approved
>>
>>
>> Comment:
>>
>> Please follow all the theme review guidelines before resubmitting this
>> theme.
>> http://codex.wordpress.org/Theme_Review
>>
>> '''WP Debug'''
>>
>> All themes should be tested with `WP_DEBUG` turned on and all debug
>> issues
>> cleared before submission.
>>
>> {{{
>> Notice: get_bloginfo was called with an argument that is deprecated
>> since
>> version 2.2! The home option is deprecated for the family of bloginfo()
>> functions. Use the url option instead. in C:\xampplite\htdocs\wp-
>> includes\functions.php on line 3376
>>
>> Notice: Undefined variable: tmpcat1 in C:\xampplite\htdocs\wp-
>> content\themes\test\latestcontent.php on line 26
>>
>> Notice: Undefined variable: tmpcat2 in C:\xampplite\htdocs\wp-
>> content\themes\test\latestcontent.php on line 26
>>
>> Notice: Undefined variable: excat in C:\xampplite\htdocs\wp-
>> content\themes\test\botpanel.php on line 27
>>
>> WordPress database error: [You have an error in your SQL syntax; check
>> the
>> manual that corresponds to your MySQL server version for the right
>> syntax
>> to use near '' at line 4]
>> SELECT comment_count,ID,post_title FROM wp_posts ORDER BY comment_count
>> DESC LIMIT 0
>>
>> Notice: Undefined index: action in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 13
>>
>> Notice: Undefined index: action in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 22
>>
>> Notice: Undefined index: saved in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 36
>>
>> Notice: Undefined index: reset in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 37
>>
>> Notice: Undefined index: tpsh_headop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: id in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_featop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_highop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_imgop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_exop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_vidop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_exvidop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_pageop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_pagehierop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_cateop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_catehierop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_countop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_emptyop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_archop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_countarc in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_tagop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>>
>> Notice: Undefined index: tpsh_botop in C:\xampplite\htdocs\wp-
>> content\themes\test\controlpanel.php on line 15
>> }}}
>>
>> '''Theme Check'''
>>
>> Results from the theme check script:
>>
>> * WARNING: TimThumb detected in file timthumb.php. Version 1.14 is out
>> of
>> date!
>> * REQUIRED: Please remove any extraneous directories like .git or .svn
>> from the ZIP file before uploading it.
>> * REQUIRED: get_bloginfo('home') was found in the file sidebar.php. Use
>> get_bloginfo( 'url' ) instead.
>> * REQUIRED: bloginfo('home') was found in the file header.php. Use
>> bloginfo( 'url' ) instead.
>>
>> '''TimThumb'''
>>
>> Themes are required to use the WordPress thumbnail system if displaying
>> thumbnails. TimThumb cannot be used as a replacement for this
>> functionality.
>>
>> '''Theme Options'''
>>
>> The theme options page has too many security vulnerabilities to approve
>> this theme.
>>
>> The theme uses the `edit_themes` capability to add the theme settings
>> page. The correct capability is `edit_theme_options`.
>>
>> None of the options are validated or sanitized before entering data into
>> the database nor are options escaped on output in the form elements.
>> Theme author should read up on data validation:
>> http://codex.wordpress.org/Data_Validation
>>
>> The settings page does no nonce checking:
>> http://codex.wordpress.org/WordPress_Nonces
>>
>> It is also highly recommended that the theme use the Settings API, which
>> is easier to use, more secure, and takes care of a lot of the hard work
>> of
>> settings pages:
>> http://codex.wordpress.org/Settings_API
>>
>> For a good tutorial on using the Settings API, see:
>>
>> http://planetozh.com/blog/2009/05/handling-plugins-options-in-wordpress-28
>> -with-register_setting/
>>
>> If you want to check out a theme with a secure and solidly-coded theme
>> settings page, check out this theme:
>> http://wordpress.org/extend/themes/coraline
>>
>> '''Review'''
>>
>> If you have any questions about the review, please check the Theme
>> Review
>> guidelines or ask in the form below. I'll be happy to help out.
>> http://codex.wordpress.org/Theme_Review
>>
>> Note that this is not a complete review. Other theme reviewers may find
>> other issues. Please follow all the notes in the Theme Review
>> guidelines.
>>
>> --
>> Ticket URL: <https://themes.trac.wordpress.org/ticket/2407#comment:2>
>> WordPress Themes <http://themes.trac.wordpress.org/>
>> WordPress.org Theme Directory Reviews
>>
>
>
> --
> Rashed Latif
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
More information about the theme-reviewers
mailing list