[theme-reviewers] Article on how to create a Theme Options Page for WordPress

[Daniel Tara]

Thanks. Fixed :)

 

From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Mike
Little
Sent: Thursday, January 13, 2011 6:58 PM
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] Article on how to create a Theme Options Page
for WordPress

 

Hi Daniel

I've left some comments on the article, because your child theme breaks
WordPress! 

You should prefix all variables and functions that are in global scope with
your unique prefix to avoid clashing with WordPress or any other
themes/plugins. In this case it was the $cat used in your loop.

 

Secondly, I wouldn't do the aggressive no-html filtering on the footer
copyright and intro text. These are being entered by a logged in user with
rights to modify theme options. If they wanted to, they could do much harm
without resorting to XSS. 

 

Thirdly you still have 'manage_options' as the capability required to access
the options page instead of 'edit_theme_options'.

 

 

Mike
-- 
Mike Little
http://zed1.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110113/b9104b99/attachment.htm>