[theme-reviewers] Theme Ticket Request

[Chip Bennett]

That's a great idea for documenting Oenology. I'll be sure to add the
default parameters for all arguments in the function documentation. I had
left them out, since I wasn't modifying any of them previously.

But for a normal Theme, I wouldn't flag it in a review for failing to
replicate a default argument, even in the case of modifying only one of a
before/after argument pair.

Chip

On Mon, Jan 10, 2011 at 9:42 AM, Edward Caissie <edward.caissie at gmail.com>wrote:

> In most cases, if a function has 'before' and 'after' paramters that can be
> set; and, the 'before' parameter opens a "container" the 'after' parameter
> should close it explicitly be it the default or not.
>
> Chip, in the case of your theme, I would explicitly close using the 'after'
> parameter but comment explaining it is not strictly necessary (following in
> the concept of my understanding of your theme's underlying premises). If
> someone chooses to modify your theme and change that particular bit of code
> to some other container such as 'div' or 'span' the explicit 'after'
> statement would be a good indicator they need to specify the closing tag
> there.
>
> Just a thought ...
>
>
> Cais.
>
>
> On Mon, Jan 10, 2011 at 10:26 AM, Philip M. Hofer (Frumph) <
> philip at frumph.net> wrote:
>
>>  just need a clear:both on #page-link is all on twentyten etc.
>>
>>
>>
>> ----- Original Message -----
>> *From:* Edward Caissie <edward.caissie at gmail.com>
>> *To:* theme-reviewers at lists.wordpress.org
>> *Sent:* Monday, January 10, 2011 6:37 AM
>> *Subject:* Re: [theme-reviewers] Theme Ticket Request
>>
>> Fortunately, I'm not seeing an ill effect on my themes, but I use a
>> clearing <div> after the_content() etc. I believe the method is still
>> considered a "hack" by some, but it works (*grin*)
>>
>>
>> Cais.
>>
>> On Mon, Jan 10, 2011 at 8:48 AM, Chip Bennett <chip at chipbennett.net>wrote:
>>
>>> Indeed; it's a previously untested test case (floated content at the end
>>> of the last page of a multiple-page post).
>>>
>>> I'll be adding a minor fix for Oenology as well, based on this test case.
>>> :)
>>>
>>> Chip
>>>
>>>
>>> On Sat, Jan 8, 2011 at 8:43 PM, Edward Caissie <edward.caissie at gmail.com
>>> > wrote:
>>>
>>>> Umm ... does Twenty Ten really not clear floats correctly?!
>>>>
>>>>
>>>> On Sat, Jan 8, 2011 at 9:39 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>>
>>>>> wpthemetestdata.wordpress.com
>>>>>
>>>>> It's not yet ready to export a new XML yet, but I can pull one for you
>>>>> if you'd like?
>>>>>
>>>>> Chip
>>>>>
>>>>>
>>>>> On Sat, Jan 8, 2011 at 8:28 PM, <michael at mfields.org> wrote:
>>>>>
>>>>>> Chip,
>>>>>>
>>>>>> Where can this new data be downloaded at? I just downloaded this:
>>>>>>
>>>>>> http://svn.automattic.com/wpcom-themes/demo/test-data.2010-08-02.xml
>>>>>>
>>>>>> and it hasn't changed. Is there another file?
>>>>>>
>>>>>> Thanks!
>>>>>> -Mike
>>>>>>
>>>>>> > You mean, you didn't like the one I added to wpthemetestdata? :)
>>>>>> >
>>>>>> > On Sat, Jan 8, 2011 at 8:00 PM, Edward Caissie
>>>>>> > <edward.caissie at gmail.com>wrote:
>>>>>> >
>>>>>> >> I think we found our content sample for post-format: audio ...
>>>>>> thanks,
>>>>>> >> Chip!
>>>>>> >>
>>>>>> >>
>>>>>> >> On Sat, Jan 8, 2011 at 11:36 AM, Chip Bennett
>>>>>> >> <chip at chipbennett.net>wrote:
>>>>>> >>
>>>>>> >>> It's on the internet archive:
>>>>>> >>> http://www.archive.org/details/SweetChild2 (stream
>>>>>> >>> or download)
>>>>>> >>>
>>>>>> >>> Enjoy!
>>>>>> >>>
>>>>>> >>>
>>>>>> >>> On Sat, Jan 8, 2011 at 10:32 AM, Edward Caissie
>>>>>> >>> <edward.caissie at gmail.com
>>>>>> >>> > wrote:
>>>>>> >>>
>>>>>> >>>> Is it a linkable MP3 ... I'd like to hear that
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>> On Fri, Jan 7, 2011 at 10:53 PM, Chip Bennett
>>>>>> >>>> <chip at chipbennett.net>wrote:
>>>>>> >>>>
>>>>>> >>>>> At this very moment, I am listening to a bluegrass version of
>>>>>> Sweet
>>>>>> >>>>> Child Of Mine... don't act like you're not jealous! ;)
>>>>>> >>>>>
>>>>>> >>>>>
>>>>>> >>>>> On Fri, Jan 7, 2011 at 6:19 PM, Philip M. Hofer (Frumph) <
>>>>>> >>>>> philip at frumph.net> wrote:
>>>>>> >>>>>
>>>>>> >>>>>>  Little child theme of miiiiine...... ♫
>>>>>> >>>>>>
>>>>>> >>>>>> ----- Original Message -----
>>>>>> >>>>>> *From:* Edward Caissie <edward.caissie at gmail.com>
>>>>>> >>>>>> *To:* theme-reviewers at lists.wordpress.org
>>>>>> >>>>>> *Sent:* Friday, January 07, 2011 4:15 PM
>>>>>> >>>>>> *Subject:* Re: [theme-reviewers] Theme Ticket Request
>>>>>> >>>>>>
>>>>>> >>>>>> Ahh ... good, didn't want you to be cursed by GnR again
>>>>>> (*grin*)
>>>>>> >>>>>>
>>>>>> >>>>>> On Fri, Jan 7, 2011 at 7:01 PM, Philip M. Hofer (Frumph) <
>>>>>> >>>>>> philip at frumph.net> wrote:
>>>>>> >>>>>>
>>>>>> >>>>>>>  Yeah, just got it now, looks like Chip snagged it before I
>>>>>> could
>>>>>> >>>>>>> ;)
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>>   ----- Original Message -----
>>>>>>  >>>>>>> *From:* Edward Caissie <edward.caissie at gmail.com>
>>>>>> >>>>>>> *To:* theme-reviewers at lists.wordpress.org
>>>>>> >>>>>>> *Sent:* Friday, January 07, 2011 3:59 PM
>>>>>> >>>>>>> *Subject:* Re: [theme-reviewers] Theme Ticket Request
>>>>>> >>>>>>>
>>>>>> >>>>>>> (Hey Phil, are you reading this?)
>>>>>> >>>>>>>
>>>>>> >>>>>>> Welcome to the jungle, Josh!
>>>>>> >>>>>>>
>>>>>> >>>>>>> Glad to have your help.
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>> Cais.
>>>>>> >>>>>>>
>>>>>> >>>>>>> On Fri, Jan 7, 2011 at 6:46 PM, Chip Bennett
>>>>>> >>>>>>> <chip at chipbennett.net>wrote:
>>>>>> >>>>>>>
>>>>>> >>>>>>>> Here you go!
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> http://themes.trac.wordpress.org/ticket/2478
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>  <http://themes.trac.wordpress.org/ticket/2478#>Here's what
>>>>>> I
>>>>>> >>>>>>>> would
>>>>>> >>>>>>>> suggest:
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> 1) Review previous tickets, and ensure that previous-ticket
>>>>>> >>>>>>>> comments
>>>>>> >>>>>>>> have been addressed
>>>>>> >>>>>>>> 2) Check the Theme's output using the Theme Check plugin
>>>>>> >>>>>>>> 3) Step through the Theme Review Guidelines, and note any
>>>>>> issues
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> Let us know if you have any questions!
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> Thanks for offering to help,
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> Chip
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>   On Fri, Jan 7, 2011 at 5:32 PM, Josh Stauffer <
>>>>>> >>>>>>>> joshstauffer at gmail.com> wrote:
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>>   Hello,
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> May I please be assigned a Theme from the Theme Review Trac
>>>>>> >>>>>>>>> Queue?
>>>>>> >>>>>>>>> I'm new so please take it easy on me.
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> Where can I find the exact process to follow? 5.2 -
>>>>>> >>>>>>>>> http://make.wordpress.org/themes/about/how-to-join-wptrt/
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> Thanks,
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> Josh
>>>>>> >>>>>>>>> WordPress.org username: joshstauffer
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> _______________________________________________
>>>>>> >>>>>>>>> theme-reviewers mailing list
>>>>>> >>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> >>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> _______________________________________________
>>>>>> >>>>>>>> theme-reviewers mailing list
>>>>>> >>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> >>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>
>>>>>> >>>>>>>  ------------------------------
>>>>>> >>>>>>>
>>>>>> >>>>>>> _______________________________________________
>>>>>> >>>>>>> theme-reviewers mailing list
>>>>>> >>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> >>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>> _______________________________________________
>>>>>> >>>>>>> theme-reviewers mailing list
>>>>>> >>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> >>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>  ------------------------------
>>>>>> >>>>>>
>>>>>> >>>>>> _______________________________________________
>>>>>> >>>>>> theme-reviewers mailing list
>>>>>> >>>>>> theme-reviewers at lists.wordpress.org
>>>>>> >>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>> _______________________________________________
>>>>>> >>>>>> theme-reviewers mailing list
>>>>>> >>>>>> theme-reviewers at lists.wordpress.org
>>>>>> >>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>
>>>>>> >>>>> _______________________________________________
>>>>>> >>>>> theme-reviewers mailing list
>>>>>> >>>>> theme-reviewers at lists.wordpress.org
>>>>>> >>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>>>
>>>>>> >>>>>
>>>>>> >>>>
>>>>>> >>>> _______________________________________________
>>>>>> >>>> theme-reviewers mailing list
>>>>>> >>>> theme-reviewers at lists.wordpress.org
>>>>>> >>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>
>>>>>> >>> _______________________________________________
>>>>>> >>> theme-reviewers mailing list
>>>>>> >>> theme-reviewers at lists.wordpress.org
>>>>>> >>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>>
>>>>>> >>>
>>>>>> >>
>>>>>> >> _______________________________________________
>>>>>> >> theme-reviewers mailing list
>>>>>> >> theme-reviewers at lists.wordpress.org
>>>>>> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >>
>>>>>> >>
>>>>>> > _______________________________________________
>>>>>> > theme-reviewers mailing list
>>>>>> > theme-reviewers at lists.wordpress.org
>>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>> >
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>  ------------------------------
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110110/9401240c/attachment-0001.htm>