[theme-reviewers] Shaan WP Theme

[Chip Bennett]

And removing unnecessary closing-opening PHP tags is pretty much always a
good idea. They're completely unnecessary, and are bound to create problems.

Chip

On Mon, Jan 3, 2011 at 7:57 AM, Jay <furcifer at furcifer.me> wrote:

> Blank lines be the devil, if you use an editor like Php Designer it has an
> option to automaticly remove all blank lines.
>
> "Otto" <otto at ottodestruct.com> wrote:
>
> >On Mon, Jan 3, 2011 at 5:29 AM, Pritam P Hans <pritam.hans at gmail.com>
> >wrote:
> >> Hi friends,
> >>
> >> A very happy new year to all. One of my WP themes (Shaan --
> >> http://wordpress.org/extend/themes/shaan) has been recently included
> >in the
> >> theme repository. I have received a two complaints regarding not
> >being able
> >> to log in to WP after installing the theme. Is it an error with the
> >theme?
> >> Can you please help me solve the issue?
> >
> >
> >Your main problem is this:
> >
> ><?php //Retrieve Theme Options Data
> >global $options;
> >$options = get_option('p2h_theme_options');
> >?>
> >
> ><?php
> >$functions_path = TEMPLATEPATH . '/functions/';
> >//Theme Options
> >require_once ($functions_path . 'theme-options.php');
> >...
> >
> >See how it has the ?> then the empty line, then the <?php again? That
> >will cause it to output a single blank line, which will break the
> >login process because of the cookies being unable to be sent.
> >
> >The functions.php file should never, ever, ever, ever produce output
> >on inclusion.
> >
> >-Otto
> >_______________________________________________
> >theme-reviewers mailing list
> >theme-reviewers at lists.wordpress.org
> >http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
> --
> Mobile, wolf is mobile.
> Http://furcifer.net
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110103/15434f5e/attachment.htm>