[theme-reviewers] [WordPress Themes] #2872: THEME: ATOM - 1.3
Edward Caissie
edward.caissie at gmail.com
Sat Feb 12 00:03:50 UTC 2011
Perhaps its just me, but I really am beginning to believe this author wants
to be credited with making the new round wheel as the old round wheel wasn't
circular enough?!
On Fri, Feb 11, 2011 at 6:57 PM, WordPress Themes <
theme-reviewers at lists.wordpress.org> wrote:
> #2872: THEME: ATOM - 1.3
> ----------------------------+------------------------
> Reporter: digitalnature | Owner: Frumph
> Type: theme | Status: closed
> Resolution: not-approved | Keywords: theme-atom,
> ----------------------------+------------------------
>
> Comment (by digitalnature):
>
> Replying to [comment:24 Frumph]:
> > The comment_form() can use the 'fields' portion of the $args array that
> can be passed to the comment_form().
> >
> > What I see you trying to justify with the comment_form() is the use of
> the jquery unhide on mouseover for the reply - which while looking at your
> output code and the $args that can be passed to the comment_form it
> appears there's no reason why you couldn't use the comment_form().
>
> no.
> check out how atom_comment_form() looks like, and try implementing the
> same markup with comment_form().
> the only way to achive that is by passing certain html tags in $args, and
> closing these tags in a hook. That's unacceptable, and I think you
> understand why...
>
> > - post thumbnail functions, there's a plugin to regenerate your
> thumbnail images if you need to. If there is an issue EVER where it
> doesn't find a thumbnail then this should be brought up as a core trac
> ticket, I have never seen a case where a thumbnail was not generated.
> There is even code for you to create your own additional thumbnail sizes.
>
> yes, I know about that plugin, but other people might not. The theme uses
> these functions to create additional thumbnails. The problem appears when
> the user changes the thumbnail size (Atom allows you to do this).
> Obviously you didn't look or test the theme so you don't quite understand
> what I'm talking about...
>
> --
> Ticket URL: <http://themes.trac.wordpress.org/ticket/2872#comment:26>
> WordPress Themes <http://themes.trac.wordpress.org/>
> WordPress.org Theme Directory Reviews
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110211/2e73b966/attachment.htm>
More information about the theme-reviewers
mailing list